Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Unified Diff: runtime/vm/compiler.cc

Issue 9836064: Stop ignoring compilation errors on compile_all (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
===================================================================
--- runtime/vm/compiler.cc (revision 5833)
+++ runtime/vm/compiler.cc (working copy)
@@ -318,29 +318,19 @@
RawError* Compiler::CompileAllFunctions(const Class& cls) {
- Isolate* isolate = Isolate::Current();
Error& error = Error::Handle();
- LongJump* base = isolate->long_jump_base();
- LongJump jump;
- isolate->set_long_jump_base(&jump);
- if (setjmp(*jump.Set()) == 0) {
- Array& functions = Array::Handle(cls.functions());
- Function& func = Function::Handle();
- for (int i = 0; i < functions.Length(); i++) {
- func ^= functions.At(i);
- ASSERT(!func.IsNull());
- if (!func.HasCode() && !func.IsAbstract()) {
- const Error& error = Error::Handle(CompileFunction(func));
- if (!error.IsNull()) {
- return error.raw();
- }
+ Array& functions = Array::Handle(cls.functions());
+ Function& func = Function::Handle();
+ for (int i = 0; i < functions.Length(); i++) {
+ func ^= functions.At(i);
+ ASSERT(!func.IsNull());
+ if (!func.HasCode() && !func.IsAbstract()) {
+ error = CompileFunction(func);
+ if (!error.IsNull()) {
+ return error.raw();
}
}
- } else {
- error = isolate->object_store()->sticky_error();
- isolate->object_store()->clear_sticky_error();
}
- isolate->set_long_jump_base(base);
return error.raw();
}
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698