Allow constant folding of && and ||.

Allow constant folding of && and ||.

Committed: https://code.google.com/p/dart/source/detail?r=5865

[ngeoffray, 2012-03-26 13:19:09]

looks good, but

http://codereview.chromium.org/9810027/diff/4001/frog/leg/operations.dart
File frog/leg/operations.dart (right):

http://codereview.chromium.org/9810027/diff/4001/frog/leg/operations.dart#new...
frog/leg/operations.dart:115: if (resultValue === null) return null;
I believe this can never be true.

[karlklose, 2012-03-26 13:24:52]

http://codereview.chromium.org/9810027/diff/4001/frog/leg/operations.dart
File frog/leg/operations.dart (right):

http://codereview.chromium.org/9810027/diff/4001/frog/leg/operations.dart#new...
frog/leg/operations.dart:115: if (resultValue === null) return null;
Not in the current subclasses, that is correct. I will remove it.

[floitsch, 2012-03-26 18:00:13]

LGTM.

[karlklose, 2012-03-27 07:25:10]

Thanks, Nicolas and Florian.

[Lasse Reichstein Nielsen, 2012-03-27 07:48:53]

dbc

http://codereview.chromium.org/9810027/diff/5005/frog/leg/operations.dart
File frog/leg/operations.dart (right):

http://codereview.chromium.org/9810027/diff/5005/frog/leg/operations.dart#new...
frog/leg/operations.dart:110: Constant fold(Constant left, Constant right) {
This seems like a pretty weak folding, if it requires the right-hand-side to be
constant.
Is it not possible to fold if just the LHS is constant and the short-circuiting
value?

http://codereview.chromium.org/9810027/diff/5005/frog/leg/operations.dart#new...
frog/leg/operations.dart:117: return null;
If left or right are not boolean, you can still fold, since any non-boolean is
converted to false.

[karlklose, 2012-03-27 07:58:26]

I don't think that I am allowed to do any more for compile time constants.