frog/leg/compile_time_constants.dart - Issue 9810027: Allow constant folding of && and ||.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: frog/leg/compile_time_constants.dart

Issue 9810027: Allow constant folding of && and ||. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comment. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: frog/leg/compile_time_constants.dart

diff --git a/frog/leg/compile_time_constants.dart b/frog/leg/compile_time_constants.dart

index 7fdfbbe43a1d29006a9f103e5b20e8b30f79f90e..e98234103a9045de9651a2c03e908d4172b13e48 100644

--- a/frog/leg/compile_time_constants.dart

+++ b/frog/leg/compile_time_constants.dart

@@ -878,6 +878,12 @@ class CompileTimeConstantEvaluator extends AbstractVisitor {

case "^":

folded = const BitXorOperation().fold(left, right);

break;

+ case "||":

+ folded = const BooleanOr().fold(left, right);

+ break;

+ case "&&":

+ folded = const BooleanAnd().fold(left, right);

+ break;

case "<<":

folded = const ShiftLeftOperation().fold(left, right);

break;

« no previous file with comments | « no previous file | frog/leg/operations.dart » ('j') | frog/leg/operations.dart » ('J')