Issue 9726011: Implement StaticGetter and StaticSetter in new compiler.

Issue 9726011: Implement StaticGetter and StaticSetter in new compiler. (Closed)

Created:
8 years, 9 months ago by regis

Modified:
8 years, 9 months ago

Reviewers:
Kevin Millikin (Google), srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement StaticGetter and StaticSetter in new compiler. Committed: https://code.google.com/p/dart/source/detail?r=5664

Patch Set 4 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -58 lines)			Patch
M	runtime/vm/code_generator_ia32.cc	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/code_generator_x64.cc	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1	2 chunks	+30 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	4 chunks	+35 lines, -15 lines	0 comments	Download
	runtime/vm/intermediate_language.h	View	1	3 chunks	+27 lines, -33 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM with one question. https://chromiumcodereview.appspot.com/9726011/diff/1/runtime/vm/code_generator_ia32.cc File runtime/vm/code_generator_ia32.cc (right): https://chromiumcodereview.appspot.com/9726011/diff/1/runtime/vm/code_generator_ia32.cc#newcode2449 runtime/vm/code_generator_ia32.cc:2449: ASSERT(!function.IsNull()); Why not a compile ...

8 years, 9 months ago (2012-03-19 22:03:53 UTC) #2

regis

8 years, 9 months ago (2012-03-19 22:54:28 UTC) #3

Thanks

https://chromiumcodereview.appspot.com/9726011/diff/1/runtime/vm/code_generat...
File runtime/vm/code_generator_ia32.cc (right):

https://chromiumcodereview.appspot.com/9726011/diff/1/runtime/vm/code_generat...
runtime/vm/code_generator_ia32.cc:2449: ASSERT(!function.IsNull());
On 2012/03/19 22:03:53, srdjan wrote:
> Why not a compile time error?

Giving an error from the code generator does not seem to be the right thing to
do. Now, the parser has a comment about this. It already checked that a setter
exists. The getter can be transformed into a setter. I do not see how to trigger
this error and all tests pass with this assert. I'll check with Matthias and
leave the assert for now.

https://chromiumcodereview.appspot.com/9726011/diff/1/runtime/vm/code_generat...
runtime/vm/code_generator_ia32.cc:2480: ASSERT(!function.IsNull());
On 2012/03/19 22:03:53, srdjan wrote:
> Ditto.

This case is definitely checked by the parser and the function should never be
null here.

https://chromiumcodereview.appspot.com/9726011/diff/1/runtime/vm/code_generat...
File runtime/vm/code_generator_x64.cc (right):

https://chromiumcodereview.appspot.com/9726011/diff/1/runtime/vm/code_generat...
runtime/vm/code_generator_x64.cc:2457: ASSERT(!function.IsNull());
On 2012/03/19 22:03:53, srdjan wrote:
> Ditto

Ditto.

https://chromiumcodereview.appspot.com/9726011/diff/1/runtime/vm/code_generat...
runtime/vm/code_generator_x64.cc:2488: ASSERT(!function.IsNull());
On 2012/03/19 22:03:53, srdjan wrote:
> Ditto

This case is definitely checked by the parser and the function should never be
null here.

Expand Messages | Collapse Messages