Implement StaticGetter and StaticSetter in new compiler.

runtime/vm/code_generator_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/code_generator.h"
 
 #include "lib/error.h"
@@ skipping 2062 matching lines @@
     // Build argument array to pass to the interpolation function.
     GrowableArray<const Object*> interpolate_arg;
     interpolate_arg.Add(&literals);
     const Array& kNoArgumentNames = Array::Handle();
     // Call the interpolation function.
     String& concatenated = String::ZoneHandle();
     concatenated ^= DartEntry::InvokeStatic(interpol_func,
                                             interpolate_arg,
                                             kNoArgumentNames);
     if (concatenated.IsUnhandledException()) {
+      // TODO(hausner): Shouldn't we generate a throw?
+      // Then remove unused CodeGenerator::ErrorMsg().
       ErrorMsg(node->token_index(),
           "Exception thrown in CodeGenerator::VisitStringConcatNode");
     }
     ASSERT(!concatenated.IsNull());
     concatenated = String::NewSymbol(concatenated);
 
     __ LoadObject(EAX, concatenated);
     __ pushl(EAX);
     return;
   }
@@ skipping 344 matching lines @@
 }
 
 
 // Return result in EAX.
 void CodeGenerator::GenerateStaticGetterCall(intptr_t token_index,
                                              const Class& field_class,
                                              const String& field_name) {
   const String& getter_name = String::Handle(Field::GetterName(field_name));
   const Function& function =
       Function::ZoneHandle(field_class.LookupStaticFunction(getter_name));
-  if (function.IsNull()) {
-    ErrorMsg(token_index, "Static getter does not exist: %s",
-        getter_name.ToCString());
-  }
+  ASSERT(!function.IsNull());

[srdjan, 2012/03/19 22:03:53]

Why not a compile time error?

[regis, 2012/03/19 22:54:28]

Giving an error from the code generator does not seem to be the right thing to
do. Now, the parser has a comment about this. It already checked that a setter
exists. The getter can be transformed into a setter. I do not see how to trigger
this error and all tests pass with this assert. I'll check with Matthias and
leave the assert for now.

   __ LoadObject(ECX, function);
   const int kNumberOfArguments = 0;
   const Array& kNoArgumentNames = Array::Handle();
   __ LoadObject(EDX, ArgumentsDescriptor(kNumberOfArguments, kNoArgumentNames));
   GenerateCall(token_index,
                &StubCode::CallStaticFunctionLabel(),
                PcDescriptors::kFuncCall);
   // No arguments were pushed, hence nothing to pop.
 }
 
@@ skipping 10 matching lines @@
 }
 
 
 // Expects value on stack.
 void CodeGenerator::GenerateStaticSetterCall(intptr_t token_index,
                                              const Class& field_class,
                                              const String& field_name) {
   const String& setter_name = String::Handle(Field::SetterName(field_name));
   const Function& function =
       Function::ZoneHandle(field_class.LookupStaticFunction(setter_name));
+  ASSERT(!function.IsNull());

[srdjan, 2012/03/19 22:03:53]

Ditto.

[regis, 2012/03/19 22:54:28]

This case is definitely checked by the parser and the function should never be
null here.

   __ LoadObject(ECX, function);
   const int kNumberOfArguments = 1;  // value.
   const Array& kNoArgumentNames = Array::Handle();
   __ LoadObject(EDX, ArgumentsDescriptor(kNumberOfArguments, kNoArgumentNames));
   GenerateCall(token_index,
                &StubCode::CallStaticFunctionLabel(),
                PcDescriptors::kFuncCall);
   __ addl(ESP, Immediate(kNumberOfArguments * kWordSize));
 }
 
@@ skipping 191 matching lines @@
   const Error& error = Error::Handle(
       Parser::FormatError(script, token_index, "Error", format, args));
   va_end(args);
   Isolate::Current()->long_jump_base()->Jump(1, error);
   UNREACHABLE();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32