Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9706018: Make string interpolations be compile-time-constants. (Closed)

Created:
8 years, 9 months ago by Lasse Reichstein Nielsen
Modified:
8 years, 9 months ago
Reviewers:
floitsch, ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make string interpolations be compile-time-constants. Based on StringInterpolation change that hasn't been committed yet. Committed: https://code.google.com/p/dart/source/detail?r=5676

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated to tip of tree. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M frog/leg/compile_time_constants.dart View 1 1 chunk +24 lines, -4 lines 0 comments Download
M tests/co19/co19-leg.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language-leg.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Lasse Reichstein Nielsen
8 years, 9 months ago (2012-03-14 15:29:54 UTC) #1
floitsch
LGTM.
8 years, 9 months ago (2012-03-14 16:11:00 UTC) #2
floitsch
But please add tests.
8 years, 9 months ago (2012-03-14 16:11:10 UTC) #3
ngeoffray
DBC https://chromiumcodereview.appspot.com/9706018/diff/1/frog/leg/compile_time_constants.dart File frog/leg/compile_time_constants.dart (right): https://chromiumcodereview.appspot.com/9706018/diff/1/frog/leg/compile_time_constants.dart#newcode772 frog/leg/compile_time_constants.dart:772: if (node.dartString !== null) { !node.isInterpolation https://chromiumcodereview.appspot.com/9706018/diff/1/frog/leg/compile_time_constants.dart#newcode797 frog/leg/compile_time_constants.dart:797: ...
8 years, 9 months ago (2012-03-15 08:09:41 UTC) #4
Lasse Reichstein Nielsen
https://chromiumcodereview.appspot.com/9706018/diff/1/frog/leg/compile_time_constants.dart File frog/leg/compile_time_constants.dart (right): https://chromiumcodereview.appspot.com/9706018/diff/1/frog/leg/compile_time_constants.dart#newcode772 frog/leg/compile_time_constants.dart:772: if (node.dartString !== null) { For consistency :) https://chromiumcodereview.appspot.com/9706018/diff/1/frog/leg/compile_time_constants.dart#newcode797 ...
8 years, 9 months ago (2012-03-15 08:39:09 UTC) #5
floitsch
8 years, 9 months ago (2012-03-20 22:19:03 UTC) #6 
where are the tests?

Powered by Google App Engine
This is Rietveld 408576698