Make string interpolations be compile-time-constants.

frog/leg/compile_time_constants.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Constant implements Hashable {
   const Constant();
 
   bool isNull() => false;
   bool isBool() => false;
   bool isTrue() => false;
@@ skipping 315 matching lines @@
         key.writeJsCode(buffer, handler);
         buffer.add(": ");
         Constant value = values[i];
         // TODO(floitsch): share this code with the ListConstant and
         // ConstructedConstant.
         if (value.isObject()) {
           String name = handler.getNameForConstant(value);
           buffer.add("$isolatePrototype.$name");
         } else {
           value.writeJsCode(buffer, handler);
-        }      
+        }
       }
-      buffer.add("}");      
+      buffer.add("}");
     }
 
     void badFieldCountError() {
       handler.compiler.internalError(
           "Compiler and ConstantMap disagree on number of fields.");
     }
 
     ClassElement classElement = type.element;
     buffer.add("new ");
     buffer.add(handler.getJsConstructor(classElement));
@@ skipping 412 matching lines @@
   }
 
   Constant visitLiteralNull(LiteralNull node) {
     return new NullConstant();
   }
 
   Constant visitLiteralString(LiteralString node) {
     return new StringConstant(node.dartString);
   }
 
+  Constant visitStringJuxtapostion(StringJuxtaposition node) {
+    if (node.dartString !== null) {

[ngeoffray, 2012/03/15 08:09:41]

!node.isInterpolation

[Lasse Reichstein Nielsen, 2012/03/15 08:39:09]

For consistency :)

+      return new StringConstant(node.dartString);
+    }
+    StringConstant left = evaluate(node.left);
+    StringConstant right = evaluate(node.right);
+    return new StringConstant(new DartString.concat(left.value, right.value));
+  }
+
+  Constant visitStringInterpolation(StringInterpolation node) {
+    StringConstant initialString = evaluate(node.string);
+    DartString accumulator = initialString.value;
+    for (StringInterpolationPart part in node.parts) {
+      Constant expression = evaluate(part.expression);
+      DartString expressionString;
+      if (expression.isNum() || expression.isBool()) {
+        Object value = expression.value;
+        expressionString = new DartString.literal(value.toString());
+      } else if (expression.isString()) {
+        expressionString = expression.value;
+      } else {
+        error(part.expression);
+      }
+      accumulator = new DartString.concat(accumulator, expressionString);
+      StringConstant partString = evaluate(part.string);
+      accumulator = new DartString.concat(accumulator, partString.value);
+    };

[ngeoffray, 2012/03/15 08:09:41]

extra ';'

[Lasse Reichstein Nielsen, 2012/03/15 08:39:09]

well spotted.

+    return new StringConstant(accumulator);
+  }
+
   // TODO(floitsch): provide better error-messages.
   Constant visitSend(Send send) {
     Element element = elements[send];
     if (Elements.isStaticOrTopLevelField(element)) {
       if (element.modifiers === null ||
           !element.modifiers.isFinal()) {
         error(send);
       }
       return constantHandler.compileVariable(element);
     } else if (send.isPrefix) {
@@ skipping 234 matching lines @@
     return constant;
   }
 
   error(Node node) {
     // TODO(floitsch): get the list of constants that are currently compiled
     // and present some kind of stack-trace.
     MessageKind kind = MessageKind.NOT_A_COMPILE_TIME_CONSTANT;
     compiler.reportError(node, new CompileTimeConstantError(kind, const []));
   }
 }