Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 9695025: Fixes for previous CL review comments (Closed)

Created:
8 years, 9 months ago by scheglov
Modified:
8 years, 9 months ago
Reviewers:
zundel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixes for previous CL review comments R=zundel@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5375

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -45 lines) Patch
M compiler/java/com/google/dart/compiler/parser/DartScannerParserContext.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/AbstractElement.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java View 5 chunks +11 lines, -5 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Element.java View 1 chunk +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Elements.java View 6 chunks +5 lines, -13 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java View 6 chunks +6 lines, -6 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/ResolveVisitor.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 6 chunks +5 lines, -6 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/TypeVariableElementImplementation.java View 4 chunks +5 lines, -5 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/VariableElementImplementation.java View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 9 months ago (2012-03-13 00:48:24 UTC) #1
zundel
8 years, 9 months ago (2012-03-13 00:50:52 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698