Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java

Issue 9695025: Fixes for previous CL review comments (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java b/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java
index 6a7be489750d2be734683dde6e3695114374b3ff..4a88a5f93aab4f0480ea50c0922f6c0186a09e2a 100644
--- a/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java
+++ b/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java
@@ -79,7 +79,7 @@ public class ResolutionContext implements ResolutionErrorListener {
&& !Elements.isParameterOfMethodWithoutBody(element)
&& !(Elements.isStaticContext(element) && !Elements.isStaticContext(existingElement))
&& !existingElement.getModifiers().isAbstractField()) {
- SourceInfo nameSourceInfo = Elements.getNameLocation(element);
+ SourceInfo nameSourceInfo = element.getNameLocation();
String existingLocation = Elements.getRelativeElementLocation(element, existingElement);
// TODO(scheglov) remove condition once HTML will be fixed to don't have duplicates.
// http://code.google.com/p/dart/issues/detail?id=1060
@@ -92,7 +92,7 @@ public class ResolutionContext implements ResolutionErrorListener {
}
// Check for duplicate declaration in the same scope.
if (existingLocalElement != null && errorCode != null) {
- SourceInfo nameSourceInfo = Elements.getNameLocation(element);
+ SourceInfo nameSourceInfo = element.getNameLocation();
String existingLocation = Elements.getRelativeElementLocation(element, existingLocalElement);
onError(nameSourceInfo, errorCode, name, existingLocation);
}

Powered by Google App Engine
This is Rietveld 408576698