Issue 9694042: Support CallWith on attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9694042: Support CallWith on attributes. (Closed)

Created:
8 years, 9 months ago by Anton Muhin

Modified:
8 years, 9 months ago

Reviewers:
podivilov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support CallWith on attributes. And some minor refactoring. Committed: https://code.google.com/p/dart/source/detail?r=5476

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -35 lines)			Patch
	M	client/dom/scripts/systemnative.py	View		6 chunks	+50 lines, -35 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

podivilov

lgtm http://codereview.chromium.org/9694042/diff/1/client/dom/scripts/systemnative.py File client/dom/scripts/systemnative.py (right): http://codereview.chromium.org/9694042/diff/1/client/dom/scripts/systemnative.py#newcode597 client/dom/scripts/systemnative.py:597: raises_dart_exceptions = self._GenerateCallWithHandling( Please rename to raises_exceptions.

8 years, 9 months ago (2012-03-14 12:28:58 UTC) #2

Anton Muhin

8 years, 9 months ago (2012-03-14 17:49:22 UTC) #3

Thanks a lot for review, submitting

http://codereview.chromium.org/9694042/diff/1/client/dom/scripts/systemnative.py
File client/dom/scripts/systemnative.py (right):

http://codereview.chromium.org/9694042/diff/1/client/dom/scripts/systemnative...
client/dom/scripts/systemnative.py:597: raises_dart_exceptions =
self._GenerateCallWithHandling(
On 2012/03/14 12:28:58, podivilov wrote:
> Please rename to raises_exceptions.

Sorry, it was the original name.  I'll leave it for now just to submit, but
let's discuss it tomorrow.

Expand Messages | Collapse Messages