Support CallWith on attributes.

client/dom/scripts/systemnative.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the systems to generate
 native binding from the IDL database."""
 
 import emitter
 import os
@@ skipping 337 matching lines @@
         WEBCORE_CLASS_NAME=self._interface_type_info.native_type())
 
     self._cpp_header_emitter.Emit(
         self._templates.Load('cpp_header.template'),
         INTERFACE=self._interface.id,
         WEBCORE_INCLUDES=webcore_includes,
         WEBCORE_CLASS_NAME=self._interface_type_info.native_type(),
         TO_DART_VALUE=to_dart_value_emitter.Fragments(),
         DECLARATIONS=self._cpp_declarations_emitter.Fragments())
 
+  def _GenerateCallWithHandling(self, node, parameter_definitions_emitter, arguments):
+    if 'CallWith' not in node.ext_attrs:
+      return False
+
+    call_with = node.ext_attrs['CallWith']
+    if call_with == 'ScriptExecutionContext':
+      parameter_definitions_emitter.Emit(
+          '\n'
+          '        ScriptExecutionContext* context = DartUtilities::scriptExecutionContext();\n'
+          '        if (!context)\n'
+          '            return;\n')
+      arguments.append('context')
+      return False
+
+    if call_with == 'ScriptArguments|CallStack':
+      self._cpp_impl_includes.add('DOMWindow')
+      self._cpp_impl_includes.add('ScriptArguments')
+      self._cpp_impl_includes.add('ScriptCallStack')
+      self._cpp_impl_includes.add('V8Proxy')
+      self._cpp_impl_includes.add('v8')
+      parameter_definitions_emitter.Emit(
+          '\n'
+          '        v8::HandleScope handleScope;\n'
+          '        v8::Context::Scope scope(V8Proxy::mainWorldContext(DartUtilities::domWindowForCurrentIsolate()->frame()));\n'
+          '        Dart_Handle customArgument = Dart_GetNativeArgument(args, $INDEX);\n'
+          '        RefPtr<ScriptArguments> scriptArguments(DartUtilities::createScriptArguments(customArgument, exception));\n'
+          '        if (!scriptArguments)\n'
+          '            goto fail;\n'
+          '        RefPtr<ScriptCallStack> scriptCallStack(DartUtilities::createScriptCallStack());\n'
+          '        if (!scriptCallStack->size())\n'
+          '            return;\n',
+          INDEX=len(node.arguments))
+      arguments.extend(['scriptArguments', 'scriptCallStack'])
+      return True
+
+    return False
+
   def AddAttribute(self, getter, setter):
     # FIXME: Dartium does not support attribute event listeners. However, JS
     # implementation falls back to them when addEventListener is not available.
     # Make sure addEventListener is available in all EventTargets and remove
     # this check.
     if (getter or setter).type.id == 'EventListener':
       return
 
     if 'CheckSecurityForNode' in (getter or setter).ext_attrs:
       # FIXME: exclude from interface as well.
@@ skipping 18 matching lines @@
     type_info = GetIDLTypeInfo(attr.type.id)
     dart_declaration = '%s get %s()' % (
         type_info.dart_type(), DartDomNameOfAttribute(attr))
     is_custom = 'Custom' in attr.ext_attrs or 'CustomGetter' in attr.ext_attrs
     cpp_callback_name = self._GenerateNativeBinding(attr.id, 1,
         dart_declaration, 'Getter', is_custom)
     if is_custom:
       return
 
     arguments = []
+    parameter_definitions_emitter = emitter.Emitter()
+    raises_exceptions = self._GenerateCallWithHandling(attr, parameter_definitions_emitter, arguments)
+    raises_exceptions = raises_exceptions or attr.get_raises
+
     if 'Reflect' in attr.ext_attrs:
       webcore_function_name = GetIDLTypeInfo(attr.type.id).webcore_getter_name()
       if 'URL' in attr.ext_attrs:
         if 'NonEmpty' in attr.ext_attrs:
           webcore_function_name = 'getNonEmptyURLAttribute'
         else:
           webcore_function_name = 'getURLAttribute'
       arguments.append(self._GenerateWebCoreReflectionAttributeName(attr))
     else:
       webcore_function_name = CppSafeName(attr.id)
       if attr.id == 'target' and attr.type.id == 'SVGAnimatedString':
         webcore_function_name = 'svgTarget'
       else:
         webcore_function_name = re.sub(r'^(HTML|URL|JS|XML|XSLT|\w)',
                                        lambda s: s.group(1).lower(),
                                        webcore_function_name)
         webcore_function_name = re.sub(r'^(create|exclusive)',
                                        lambda s: 'is' + s.group(1).capitalize(),
                                        webcore_function_name)
       if attr.type.id.startswith('SVGAnimated'):
         webcore_function_name += 'Animated'
 
     function_expression = self._GenerateWebCoreFunctionExpression(webcore_function_name, attr)
     invocation = self._GenerateWebCoreInvocation(function_expression,
         arguments, attr.type.id, attr.ext_attrs, attr.get_raises)
-    self._GenerateNativeCallback(cpp_callback_name, '', True, invocation,
-        raises_exceptions=attr.get_raises)
+    self._GenerateNativeCallback(cpp_callback_name, parameter_definitions_emitter.Fragments(),
+        True, invocation, raises_exceptions=raises_exceptions)
 
   def _AddSetter(self, attr):
     type_info = GetIDLTypeInfo(attr.type.id)
     dart_declaration = 'void set %s(%s)' % (
         DartDomNameOfAttribute(attr), type_info.dart_type())
     is_custom = set(['Custom', 'CustomSetter', 'V8CustomSetter']) & set(attr.ext_attrs)
     cpp_callback_name = self._GenerateNativeBinding(attr.id, 2,
         dart_declaration, 'Setter', is_custom)
     if is_custom:
       return
 
     arguments = []
+    parameter_definitions_emitter = emitter.Emitter()
+    self._GenerateCallWithHandling(attr, parameter_definitions_emitter, arguments)
+
     if 'Reflect' in attr.ext_attrs:
       webcore_function_name = GetIDLTypeInfo(attr.type.id).webcore_setter_name()
       arguments.append(self._GenerateWebCoreReflectionAttributeName(attr))
     else:
       webcore_function_name = re.sub(r'^(xml(?=[A-Z])|\w)',
                                      lambda s: s.group(1).upper(),
                                      attr.id)
       webcore_function_name = 'set%s' % webcore_function_name
       if attr.type.id.startswith('SVGAnimated'):
         webcore_function_name += 'Animated'
 
     cpp_arg_name = CppSafeName(attr.id)
     arguments.append(cpp_arg_name)
 
-    parameter_definitions_emitter = emitter.Emitter()
     self._GenerateParameterAdapter(
         parameter_definitions_emitter, attr, cpp_arg_name, 0)
-    parameter_definitions = parameter_definitions_emitter.Fragments()
 
     function_expression = self._GenerateWebCoreFunctionExpression(webcore_function_name, attr)
     invocation = self._GenerateWebCoreInvocation(function_expression,
         arguments, 'void', attr.ext_attrs, attr.set_raises)
 
-    self._GenerateNativeCallback(cpp_callback_name, parameter_definitions,
+    self._GenerateNativeCallback(cpp_callback_name, parameter_definitions_emitter.Fragments(),
         True, invocation, raises_exceptions=True)
 
   def _HasNativeIndexGetter(self, interface):
     return ('CustomIndexedGetter' in interface.ext_attrs or
             'NumericIndexedGetter' in interface.ext_attrs)
 
   def _EmitNativeIndexGetter(self, interface, element_type):
     dart_declaration = '%s operator[](int index)' % element_type
     self._GenerateNativeBinding('numericIndexGetter', 2, dart_declaration,
         'Callback', True)
@@ skipping 75 matching lines @@
     cpp_callback_name = self._GenerateNativeBinding(
         native_name, 1 + len(operation.arguments), dart_declaration, 'Callback',
         is_custom)
     if is_custom:
       return
 
     # Generate callback.
     webcore_function_name = operation.ext_attrs.get('ImplementedAs', operation.id)
 
     parameter_definitions_emitter = emitter.Emitter()
-    raises_dart_exceptions = len(operation.arguments) > 0 or operation.raises
     arguments = []
-
-    # Process 'CallWith' argument.
-    if 'CallWith' in operation.ext_attrs:
-      call_with = operation.ext_attrs['CallWith']
-      if call_with == 'ScriptExecutionContext':
-        parameter_definitions_emitter.Emit(
-            '        ScriptExecutionContext* context = DartUtilities::scriptExecutionContext();\n'
-            '        if (!context)\n'
-            '            return;\n')
-        arguments.append('context')
-      elif call_with == 'ScriptArguments|CallStack':
-        raises_dart_exceptions = True
-        self._cpp_impl_includes.add('DOMWindow')
-        self._cpp_impl_includes.add('ScriptArguments')
-        self._cpp_impl_includes.add('ScriptCallStack')
-        self._cpp_impl_includes.add('V8Proxy')
-        self._cpp_impl_includes.add('v8')
-        parameter_definitions_emitter.Emit(
-            '        v8::HandleScope handleScope;\n'
-            '        v8::Context::Scope scope(V8Proxy::mainWorldContext(DartUtilities::domWindowForCurrentIsolate()->frame()));\n'
-            '        Dart_Handle customArgument = Dart_GetNativeArgument(args, $INDEX);\n'
-            '        RefPtr<ScriptArguments> scriptArguments(DartUtilities::createScriptArguments(customArgument, exception));\n'
-            '        if (!scriptArguments)\n'
-            '            goto fail;\n'
-            '        RefPtr<ScriptCallStack> scriptCallStack(DartUtilities::createScriptCallStack());\n'
-            '        if (!scriptCallStack->size())\n'
-            '            return;\n',
-            INDEX=len(operation.arguments))
-        arguments.extend(['scriptArguments', 'scriptCallStack'])
+    raises_dart_exceptions = self._GenerateCallWithHandling(

[podivilov, 2012/03/14 12:28:58]

Please rename to raises_exceptions.

[Anton Muhin, 2012/03/14 17:49:22]

Sorry, it was the original name.  I'll leave it for now just to submit, but
let's discuss it tomorrow.

+        operation, parameter_definitions_emitter, arguments)
+    raises_dart_exceptions = raises_dart_exceptions or len(operation.arguments) > 0 or operation.raises
 
     # Process Dart arguments.
     for (i, argument) in enumerate(operation.arguments):
       if (i == len(operation.arguments) - 1 and
           self._interface.id == 'Console' and
           argument.id == 'arg'):
         # FIXME: we are skipping last argument here because it was added in
         # supplemental dart.idl. Cleanup dart.idl and remove this check.
         break
       cpp_arg_name = CppSafeName(argument.id)
@@ skipping 178 matching lines @@
 
     if 'ImplementedBy' in attributes:
       arguments.insert(0, 'receiver')
       self._cpp_impl_includes.add(attributes['ImplementedBy'])
 
     return emitter.Format(invocation_template,
         FUNCTION_CALL='%s(%s)' % (function_expression, ', '.join(arguments)))
 
 def _GenerateCPPIncludes(includes):
   return ''.join(['#include "%s.h"\n' % include for include in includes])