Issue 9693051: Add type checking to some native function arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9693051: Add type checking to some native function arguments (Closed)

Created:
8 years, 9 months ago by hausner

Modified:
8 years, 9 months ago

Reviewers:
turnidge, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add type checking to some native function arguments Committed: https://code.google.com/p/dart/source/detail?r=5437

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -48 lines)			Patch
M	runtime/lib/date.cc	View	8 chunks	+20 lines, -19 lines	1 comment	Download
M	runtime/lib/error.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/lib/isolate.cc	View	2 chunks	+8 lines, -7 lines	1 comment	Download
M	runtime/lib/string.cc	View	4 chunks	+19 lines, -22 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comments. -Ivan http://codereview.chromium.org/9693051/diff/1/runtime/lib/date.cc File runtime/lib/date.cc (right): http://codereview.chromium.org/9693051/diff/1/runtime/lib/date.cc#newcode8 runtime/lib/date.cc:8: #include "vm/exceptions.h" native_entry.h should include ...

8 years, 9 months ago (2012-03-13 18:19:53 UTC) #2

lgtm

Expand Messages | Collapse Messages