Add type checking to some native function arguments

runtime/lib/isolate.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/bootstrap_natives.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_entry.h"
@@ skipping 239 matching lines @@
                              func_name) + 1;
   char* chars = reinterpret_cast<char*>(
       Isolate::Current()->current_zone()->Allocate(len));
   OS::SNPrint(chars, len, kFormat, script_name, class_name, func_name);
   return chars;
 }
 
 
 DEFINE_NATIVE_ENTRY(IsolateNatives_start, 2) {
   Isolate* preserved_isolate = Isolate::Current();
-  const Instance& runnable = Instance::CheckedHandle(arguments->At(0));
+  GET_NATIVE_ARGUMENT(Instance, runnable, arguments->At(0));

[Ivan Posva, 2012/03/13 18:19:53]

Please make a note that the second argument is ignored.

   const Class& runnable_class = Class::Handle(runnable.clazz());
   const char* class_name = String::Handle(runnable_class.Name()).ToCString();
   const Library& library = Library::Handle(runnable_class.library());
   ASSERT(!library.IsNull());
   const char* library_url = String::Handle(library.url()).ToCString();
   intptr_t port_id = 0;
   LongJump jump;
   bool init_successful = true;
   Isolate* spawned_isolate = NULL;
   void* callback_data = preserved_isolate->init_callback_data();
@@ skipping 63 matching lines @@
       PortMap::CreatePort(arguments->isolate()->message_handler());
   const Object& port = Object::Handle(ReceivePortCreate(port_id));
   if (port.IsError()) {
     Exceptions::PropagateError(port);
   }
   arguments->SetReturn(port);
 }
 
 
 DEFINE_NATIVE_ENTRY(ReceivePortImpl_closeInternal, 1) {
-  intptr_t id = Smi::CheckedHandle(arguments->At(0)).Value();
-  PortMap::ClosePort(id);
+  GET_NATIVE_ARGUMENT(Smi, id, arguments->At(0));
+  PortMap::ClosePort(id.Value());
 }
 
 
 DEFINE_NATIVE_ENTRY(SendPortImpl_sendInternal_, 3) {
-  intptr_t send_id = Smi::CheckedHandle(arguments->At(0)).Value();
-  intptr_t reply_id = Smi::CheckedHandle(arguments->At(1)).Value();
+  GET_NATIVE_ARGUMENT(Smi, send_id, arguments->At(0));
+  GET_NATIVE_ARGUMENT(Smi, reply_id, arguments->At(1));
   // TODO(iposva): Allow for arbitrary messages to be sent.
-  uint8_t* data = SerializeObject(Instance::CheckedHandle(arguments->At(2)));
+  GET_NATIVE_ARGUMENT(Instance, obj, arguments->At(2));
+  uint8_t* data = SerializeObject(obj);
 
   // TODO(turnidge): Throw an exception when the return value is false?
   PortMap::PostMessage(new Message(
-      send_id, reply_id, data, Message::kNormalPriority));
+      send_id.Value(), reply_id.Value(), data, Message::kNormalPriority));
 }
 
 }  // namespace dart