Fixed some static type warnings in vm core libraries

Fixed some static type warnings in vm core libraries

After running 'dartc' on the VM's core libraries, about 79 static type warnings popped out.
These ten or so were relatively easy to fix.

Committed: https://code.google.com/p/dart/source/detail?r=5794

[zundel, 2012-03-13 21:58:49]

See the full list of warnings in this issue
http://code.google.com/p/dart/issues/detail?id=2136

[Ivan Posva, 2012-03-14 05:34:05]

Any particular reason why you want to fix these?

-Ivan

https://chromiumcodereview.appspot.com/9692068/diff/2001/runtime/lib/integers...
File runtime/lib/integers.dart (right):

https://chromiumcodereview.appspot.com/9692068/diff/2001/runtime/lib/integers...
runtime/lib/integers.dart:144: var value = this.isNegative() ? -this : this;
Please maintain the code as it was with a local variable. If you really want to
avoid the hiding of the name then please use a different variable name:
final negative = this.isNegative();
var value = negative ? -this : this;
...
if (negative) {
  buffer.add("-");
}

Actually on second thought, I do like the name isNegative and there is a reason
why we allow shadowing.

https://chromiumcodereview.appspot.com/9692068/diff/2001/runtime/lib/regexp.dart
File runtime/lib/regexp.dart (right):

https://chromiumcodereview.appspot.com/9692068/diff/2001/runtime/lib/regexp.d...
runtime/lib/regexp.dart:16: int _start(int groupIdx) {
What is the warning here?

[zundel, 2012-03-14 12:56:21]

there is no more 'compiler' version of the dart libraries.  So, for analysis, we
have to choose an implementation of the libraries to resolve against.  For
running dart vm from the command line, that makes some libraries, like dart:io
available.  For running from dartium, you get one version of dart:html, for
running from frog, you get another. 

For now, since there are many of them, the analyzer is going to suppress
warnings in the core libraries, but I've been told a long term goal is to get
the libraries warning free.

https://chromiumcodereview.appspot.com/9692068/diff/2001/runtime/lib/regexp.dart
File runtime/lib/regexp.dart (right):

https://chromiumcodereview.appspot.com/9692068/diff/2001/runtime/lib/regexp.d...
runtime/lib/regexp.dart:16: int _start(int groupIdx) {
On 2012/03/14 05:34:05, Ivan Posva wrote:
> What is the warning here?

parameter 'group' shadows the method 'group' in the class.

[zundel, 2012-03-14 13:04:34]

https://chromiumcodereview.appspot.com/9692068/diff/2001/runtime/lib/integers...
File runtime/lib/integers.dart (right):

https://chromiumcodereview.appspot.com/9692068/diff/2001/runtime/lib/integers...
runtime/lib/integers.dart:144: var value = this.isNegative() ? -this : this;
On 2012/03/14 05:34:05, Ivan Posva wrote:
> Please maintain the code as it was with a local variable. If you really want
to
> avoid the hiding of the name then please use a different variable name:
> final negative = this.isNegative();
> var value = negative ? -this : this;
> ...
> if (negative) {
>   buffer.add("-");
> }
> 
> Actually on second thought, I do like the name isNegative and there is a
reason
> why we allow shadowing.

np, I'll revert this. 

Background: the shadowing warning is not in the spec,we were thinking it could
be optionally flipped on/off for developers that wanted it (currently there is
no way to turn it off).

[zundel, 2012-03-19 19:51:30]

ping

[Ivan Posva, 2012-03-23 20:50:44]

LGTM -ip