Fixed some static type warnings in vm core libraries

runtime/lib/regexp.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class JSRegExpMatch implements Match {
   JSRegExpMatch(this.regexp, this.str, this._match);
 
   int start() {
     return _start(0);
   }
 
   int end() {
     return _end(0);
   }
 
-  int _start(int group) {
-    return _match[(group * _kMatchPair)];
+  int _start(int groupIdx) {

[Ivan Posva, 2012/03/14 05:34:05]

What is the warning here?

[zundel, 2012/03/14 12:56:21]

parameter 'group' shadows the method 'group' in the class.

+    return _match[(groupIdx * _kMatchPair)];
   }
 
-  int _end(int group) {
-    return _match[(group * _kMatchPair) + 1];
+  int _end(int groupIdx) {
+    return _match[(groupIdx * _kMatchPair) + 1];
   }
 
-  String group(int group) {
-    return str.substringUnchecked_(_start(group), _end(group));
+  String group(int groupIdx) {
+    return str.substringUnchecked_(_start(groupIdx), _end(groupIdx));
   }
 
-  String operator [](int group) {
-    return str.substringUnchecked_(_start(group), _end(group));
+  String operator [](int groupIdx) {
+    return str.substringUnchecked_(_start(groupIdx), _end(groupIdx));
   }
 
-  List<String> groups(List<int> groups) {
-    var groupsList = new List<String>(groups.length);
-    for (int i = 0; i < groups.length; i++) {
-      int grp_idx = groups[i];
+  List<String> groups(List<int> groupsSpec) {
+    var groupsList = new List<String>(groupsSpec.length);
+    for (int i = 0; i < groupsSpec.length; i++) {
+      int grp_idx = groupsSpec[i];
       groupsList[i] = str.substringUnchecked_(_start(grp_idx), _end(grp_idx));
     }
     return groupsList;
   }
 
   int groupCount() {
     return regexp._groupCount;
   }
 
   final RegExp regexp;
@@ skipping 50 matching lines @@
 
   bool get multiLine() native "JSSyntaxRegExp_multiLine";
 
   bool get ignoreCase() native "JSSyntaxRegExp_ignoreCase";
 
   int get _groupCount() native "JSSyntaxRegExp_getGroupCount";
 
   List _ExecuteMatch(String str, int start_index)
       native "JSSyntaxRegExp_ExecuteMatch";
 }