Issue 9689023: Tiny fix in Dart_CreateIsolate to allow errors to print correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9689023: Tiny fix in Dart_CreateIsolate to allow errors to print correctly. (Closed)

Created:
8 years, 9 months ago by turnidge

Modified:
8 years, 9 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Tiny fix in Dart_CreateIsolate to allow errors to print correctly. Committed: https://code.google.com/p/dart/source/detail?r=5369

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -9 lines)			Patch
	M	runtime/vm/dart_api_impl.cc	View	1	1 chunk	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

turnidge

Separated this change out from one of my larger changes, because it was interfering with ...

8 years, 9 months ago (2012-03-12 20:02:52 UTC) #1

siva

8 years, 9 months ago (2012-03-12 20:09:39 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/9689023/diff/1/runtime/vm/dart_api_imp...
File runtime/vm/dart_api_impl.cc (right):

https://chromiumcodereview.appspot.com/9689023/diff/1/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:595: } else {
We could even get rid of this else and
do:
  }
  *error = ....
}
Not a priority for this change.

Expand Messages | Collapse Messages