Tiny fix in Dart_CreateIsolate to allow errors to print correctly.

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart.h"
@@ skipping 567 matching lines @@
 
 // --- Isolates ---
 
 
 DART_EXPORT Dart_Isolate Dart_CreateIsolate(const char* name_prefix,
                                             const uint8_t* snapshot,
                                             void* callback_data,
                                             char** error) {
   Isolate* isolate = Dart::CreateIsolate(name_prefix);
   assert(isolate != NULL);
-  DARTSCOPE_NOCHECKS(isolate);
-  const Error& error_obj =
-      Error::Handle(Dart::InitializeIsolate(snapshot, callback_data));
-  if (error_obj.IsNull()) {
-    START_TIMER(time_total_runtime);
-    return reinterpret_cast<Dart_Isolate>(isolate);
-  } else {
-    *error = strdup(error_obj.ToErrorCString());
-    Dart::ShutdownIsolate();
-    return reinterpret_cast<Dart_Isolate>(NULL);
+  {
+    DARTSCOPE_NOCHECKS(isolate);
+    const Error& error_obj =
+        Error::Handle(Dart::InitializeIsolate(snapshot, callback_data));
+    if (error_obj.IsNull()) {
+      START_TIMER(time_total_runtime);
+      return reinterpret_cast<Dart_Isolate>(isolate);
+    } else {

[siva, 2012/03/12 20:09:39]

We could even get rid of this else and
do:
  }
  *error = ....
}
Not a priority for this change.

+      *error = strdup(error_obj.ToErrorCString());
+    }
   }
+  Dart::ShutdownIsolate();
+  return reinterpret_cast<Dart_Isolate>(NULL);
 }
 
 
 DART_EXPORT void Dart_ShutdownIsolate() {
   CHECK_ISOLATE(Isolate::Current());
   STOP_TIMER(time_total_runtime);
   Dart::ShutdownIsolate();
 }
 
 
@@ skipping 2477 matching lines @@
       *buffer = NULL;
     }
     delete debug_region;
   } else {
     *buffer = NULL;
     *buffer_size = 0;
   }
 }
 
 }  // namespace dart