Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Issue 9664068: removed unused 'chromium' component (Closed)

Created:
8 years, 9 months ago by mattsh
Modified:
8 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

removed unused chromium component BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5372

Patch Set 1 #

Total comments: 4

Patch Set 2 : restored 'most' #

Patch Set 3 : fix ambiguous id problem in frogpad #

Patch Set 4 : revert patch in wrong branch #

Patch Set 5 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M tools/testing/dart/test_options.dart View 1 2 3 4 3 chunks +2 lines, -5 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 2 3 4 4 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mattsh
8 years, 9 months ago (2012-03-12 16:00:42 UTC) #1
ahe
LGTM, but wait for Bill's comments. https://chromiumcodereview.appspot.com/9664068/diff/1/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (right): https://chromiumcodereview.appspot.com/9664068/diff/1/tools/testing/dart/test_options.dart#newcode97 tools/testing/dart/test_options.dart:97: ['vm', 'frog', 'leg', ...
8 years, 9 months ago (2012-03-12 16:14:09 UTC) #2
Bill Hesse
LGTM if "most" is restored. https://chromiumcodereview.appspot.com/9664068/diff/1/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (right): https://chromiumcodereview.appspot.com/9664068/diff/1/tools/testing/dart/test_options.dart#newcode98 tools/testing/dart/test_options.dart:98: 'legium', 'webdriver', 'dartc'], Do ...
8 years, 9 months ago (2012-03-12 16:17:57 UTC) #3
mattsh
https://chromiumcodereview.appspot.com/9664068/diff/1/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (right): https://chromiumcodereview.appspot.com/9664068/diff/1/tools/testing/dart/test_options.dart#newcode98 tools/testing/dart/test_options.dart:98: 'legium', 'webdriver', 'dartc'], On 2012/03/12 16:17:57, Bill Hesse wrote: ...
8 years, 9 months ago (2012-03-12 16:22:25 UTC) #4
mattsh
https://chromiumcodereview.appspot.com/9664068/diff/1/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (right): https://chromiumcodereview.appspot.com/9664068/diff/1/tools/testing/dart/test_options.dart#newcode98 tools/testing/dart/test_options.dart:98: 'legium', 'webdriver', 'dartc'], On 2012/03/12 16:22:25, mattsh wrote: > ...
8 years, 9 months ago (2012-03-12 17:20:25 UTC) #5
Bill Hesse
most is a human-readable option, entered on the command line, that runs "Important" components. Right ...
8 years, 9 months ago (2012-03-12 17:26:25 UTC) #6
zundel
lgtm2
8 years, 9 months ago (2012-03-12 18:32:24 UTC) #7
Siggi Cherem (dart-lang)
8 years, 9 months ago (2012-03-12 19:53:43 UTC) #8
lgtm3

Powered by Google App Engine
This is Rietveld 408576698