Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9664068: removed unused 'chromium' component (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rebased Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_options.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index ceef8d31f1423716b907031445281be12e77abc7..9ddfdb4019a3851450b4124da85e9aa6b8642faf 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -586,14 +586,6 @@ class StandardTestSuite implements TestSuite {
String executable = TestUtils.compilerPath(configuration);
List<String> args = TestUtils.standardOptions(configuration);
switch (component) {
- // TODO(zundel): Remove chromium now that dartc doesn't generate code?
- case 'chromium':
- args.addAll(['--work', dir]);
- args.addAll(vmOptions);
- args.add('--ignore-unrecognized-flags');
- args.add(inputFile);
- // TODO(whesse): Add --fatal-type-errors if needed.
- break;
case 'frogium':
case 'legium':
case 'webdriver':
@@ -614,8 +606,7 @@ class StandardTestSuite implements TestSuite {
}
bool get requiresCleanTemporaryDirectory() =>
- configuration['component'] == 'dartc' ||
- configuration['component'] == 'chromium';
+ configuration['component'] == 'dartc';
/**
* Create a directory for the generated test. If a Dart language test
@@ -685,7 +676,6 @@ class StandardTestSuite implements TestSuite {
switch (configuration['component']) {
case 'dartium':
return 'application/dart';
- case 'chromium':
case 'frogium':
case 'legium':
case 'webdriver':
@@ -1111,7 +1101,6 @@ class TestUtils {
static String compilerName(Map configuration) {
String suffix = executableSuffix(configuration['component']);
switch (configuration['component']) {
- case 'chromium':
case 'dartc':
return 'compiler/bin/dartc$suffix';
case 'frogium':
« no previous file with comments | « tools/testing/dart/test_options.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698