Issue 9662043: An HStatic cannot necessarily be generate at use site.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9662043: An HStatic cannot necessarily be generate at use site. (Closed)

Created:
8 years, 9 months ago by ngeoffray

Modified:
8 years, 9 months ago

Reviewers:
Lasse Reichstein Nielsen, floitsch, kasperl

CC:
reviews_dartlang.org, kasperl, karlklose, ahe

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

An HStatic cannot necessarily be generate at use site. Committed: https://code.google.com/p/dart/source/detail?r=5313

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -1 line)			Patch
	M	frog/leg/ssa/nodes.dart	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
	A	tests/language/src/StaticPostfixOperatorTest.dart	View	1 2	1 chunk	+31 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

ngeoffray

If you consider (a++ == 0), we would generate: t0 = HStatic t1 = HAdd(t0, ...

8 years, 9 months ago (2012-03-11 13:18:45 UTC) #1

kasperl

LGTM. Should we have the same test without the try-finally?

8 years, 9 months ago (2012-03-12 06:38:02 UTC) #2

ngeoffray

Added a test without a try/finally, and also allow generateAtUseSute to non-assignable statics. PTAL

8 years, 9 months ago (2012-03-12 09:42:02 UTC) #3

LGTM.