frog/leg/ssa/nodes.dart - Issue 9662043: An HStatic cannot necessarily be generate at use site.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: frog/leg/ssa/nodes.dart

Issue 9662043: An HStatic cannot necessarily be generate at use site. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: fix test Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: frog/leg/ssa/nodes.dart

diff --git a/frog/leg/ssa/nodes.dart b/frog/leg/ssa/nodes.dart

index 6717e6426a0e7cd5b70e9cff034b12e5e1a4e6af..9f8415f8ff24d98cf38117181c8dd8ff80d5f090 100644

--- a/frog/leg/ssa/nodes.dart

+++ b/frog/leg/ssa/nodes.dart

@@ -1943,8 +1943,11 @@ class HThrow extends HControlFlow {

class HStatic extends HInstruction {

Element element;

HStatic(this.element) : super(<HInstruction>[]) {

- tryGenerateAtUseSite();

+ if (!element.isAssignable()) {

+ tryGenerateAtUseSite();

+ }

}

void prepareGvn() {

assert(!hasSideEffects());

if (!element.isAssignable()) {

« no previous file with comments | « no previous file | tests/language/src/StaticPostfixOperatorTest.dart » ('j') | no next file with comments »