Issue 9649010: Fix type checks that wrongly ignore malformed types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9649010: Fix type checks that wrongly ignore malformed types. (Closed)

Created:
8 years, 9 months ago by regis

Modified:
8 years, 9 months ago

Reviewers:
siva, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix type checks that wrongly ignored malformed types. Fix corresponding test. Fix comment in gypi file. Fix undeclared type in stream_util.dart. Committed: https://code.google.com/p/dart/source/detail?r=5243

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
M	runtime/bin/stream_util.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/uri_sources.gypi	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1 2 3	2 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/vm/code_generator_x64.cc	View	1 2 3	2 chunks	+4 lines, -1 line	0 comments	Download
M	tests/language/src/TypeVariableBoundsTest.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

Please, have another look. I removed the temporary fix reordering the libraries, since it is ...

8 years, 9 months ago (2012-03-09 17:44:09 UTC) #2

lgtm

Expand Messages | Collapse Messages