Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Unified Diff: runtime/vm/code_generator_ia32.cc

Issue 9649010: Fix type checks that wrongly ignore malformed types. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/uri_sources.gypi ('k') | runtime/vm/code_generator_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator_ia32.cc
===================================================================
--- runtime/vm/code_generator_ia32.cc (revision 5242)
+++ runtime/vm/code_generator_ia32.cc (working copy)
@@ -1432,7 +1432,8 @@
// Any expression is assignable to the Dynamic type and to the Object type.
// Skip the test.
- if (dst_type.IsDynamicType() || dst_type.IsObjectType()) {
+ if (!dst_type.IsMalformed() &&
+ (dst_type.IsDynamicType() || dst_type.IsObjectType())) {
return;
}
@@ -1467,6 +1468,8 @@
GenerateCallRuntime(node_id, token_index, kMalformedTypeErrorRuntimeEntry);
// We should never return here.
__ int3();
+
+ __ Bind(&done); // For a null object.
return;
}
« no previous file with comments | « runtime/bin/uri_sources.gypi ('k') | runtime/vm/code_generator_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698