Issue 9646030: Find diagnostic locations for use in new compiler API.

Issue 9646030: Find diagnostic locations for use in new compiler API. (Closed)

Created:
8 years, 9 months ago by ahe

Modified:
8 years, 9 months ago

Reviewers:
karlklose, ngeoffray, kasperl

CC:
reviews_dartlang.org, compiler-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Find diagnostic locations for use in new compiler API. Committed: https://code.google.com/p/dart/source/detail?r=5280

Patch Set 2 : Fix crashes and address review comments #

Total comments: 2

Patch Set 3 : rebased #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -64 lines)			Patch
M	dart/frog/leg/apiimpl.dart	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
M	dart/frog/leg/compiler.dart	View	1 2	3 chunks	+71 lines, -3 lines	0 comments	Download
M	dart/frog/leg/elements/elements.dart	View	1 2	3 chunks	+1 line, -31 lines	0 comments	Download
M	dart/frog/leg/frog_leg.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	dart/frog/leg/resolver.dart	View	1 2	5 chunks	+23 lines, -20 lines	0 comments	Download
M	dart/frog/leg/ssa/builder.dart	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
M	dart/frog/leg/tree/nodes.dart	View	1	3 chunks	+8 lines, -3 lines	0 comments	Download
M	dart/frog/tests/leg/src/mock_compiler.dart	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	dart/tests/co19/co19-leg.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. Thanks, Peter! https://chromiumcodereview.appspot.com/9646030/diff/1/dart/frog/leg/compiler.dart File dart/frog/leg/compiler.dart (right): https://chromiumcodereview.appspot.com/9646030/diff/1/dart/frog/leg/compiler.dart#newcode138 dart/frog/leg/compiler.dart:138: reportDiagnostic(span.uri, span.begin, span.end, reason, true); Maybe ...

8 years, 9 months ago (2012-03-09 09:58:59 UTC) #2

ahe

Hi Kasper and Karl, Thank you for taking a look, please take another look as ...

8 years, 9 months ago (2012-03-10 00:08:18 UTC) #4

ngeoffray

LGTM! https://chromiumcodereview.appspot.com/9646030/diff/4001/dart/frog/leg/compiler.dart File dart/frog/leg/compiler.dart (right): https://chromiumcodereview.appspot.com/9646030/diff/4001/dart/frog/leg/compiler.dart#newcode395 dart/frog/leg/compiler.dart:395: throw 'cannot find tokens to produce error message'; ...

8 years, 9 months ago (2012-03-10 10:36:58 UTC) #5

ahe

8 years, 9 months ago (2012-03-10 10:50:58 UTC) #6

Hi Nicolas,

Thank you for taking a look.

Cheers,
Peter

https://chromiumcodereview.appspot.com/9646030/diff/4001/dart/frog/leg/compil...
File dart/frog/leg/compiler.dart (right):

https://chromiumcodereview.appspot.com/9646030/diff/4001/dart/frog/leg/compil...
dart/frog/leg/compiler.dart:395: throw 'cannot find tokens to produce error
message';
On 2012/03/10 10:36:58, ngeoffray wrote:
> Should that be return const SourceSpan(null, null, null) instead?

I'm really torn about this. It really is an internal error in the compiler but
we can do better in many cases. For example: we almost always know the current
URI. Often, we may be able to get the begin token, but not the end token. I'll
add a TODO and mull it over.

Expand Messages | Collapse Messages