Use Element instead of Symbol.

Use Element instead of Symbol.
Return typed Element where possible.


R=brianwilkerson@google.com,zundel@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=5178

[Brian Wilkerson, 2012-03-08 16:12:00]

LGTM

https://chromiumcodereview.appspot.com/9633009/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/resolver/Element.java (right):

https://chromiumcodereview.appspot.com/9633009/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/resolver/Element.java:13: String
getOriginalName();
Not for this CL, but can this go away? I'm guessing that this was added to
support name mangling, which we don't need to do anymore.

[scheglov, 2012-03-08 16:46:50]

https://chromiumcodereview.appspot.com/9633009/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/resolver/Element.java (right):

https://chromiumcodereview.appspot.com/9633009/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/resolver/Element.java:13: String
getOriginalName();
On 2012/03/08 16:12:00, Brian Wilkerson wrote:
> Not for this CL, but can this go away? I'm guessing that this was added to
> support name mangling, which we don't need to do anymore.

Sure.
This CL is only about consolidating everything around Element.
Element itself will be cleaned up and probably enhanced to support for example
(as you requested) CompilationUnit.

[zundel, 2012-03-08 18:47:13]

lgtm2, just nits

https://chromiumcodereview.appspot.com/9633009/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/LibraryDepsVisitor.java (right):

https://chromiumcodereview.appspot.com/9633009/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/LibraryDepsVisitor.java:1: // Copyright
(c) 2011, the Dart project authors.  Please see the AUTHORS file
update year to 2012 (ugh)

https://chromiumcodereview.appspot.com/9633009/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/9633009/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:590: String
parameterName = namedExpression.getName().getName();
!! Not really your problem but node.getName().getName() looks funky.

[scheglov, 2012-03-08 19:14:08]

https://chromiumcodereview.appspot.com/9633009/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/LibraryDepsVisitor.java (right):

https://chromiumcodereview.appspot.com/9633009/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/LibraryDepsVisitor.java:1: // Copyright
(c) 2011, the Dart project authors.  Please see the AUTHORS file
On 2012/03/08 18:47:13, zundel wrote:
> update year to 2012 (ugh)

Done.

https://chromiumcodereview.appspot.com/9633009/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/9633009/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:590: String
parameterName = namedExpression.getName().getName();
On 2012/03/08 18:47:13, zundel wrote:
> !! Not really your problem but node.getName().getName() looks funky.

Yes, I'd like to replace this in new AST with something like in JDT.
I.e. MethodDeclaration has getName() and SimpleName has getIdentifier().