Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: compiler/javatests/com/google/dart/compiler/resolver/ResolverAuditVisitor.java

Issue 9633009: Use Element instead of Symbol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/javatests/com/google/dart/compiler/resolver/ResolverAuditVisitor.java
diff --git a/compiler/javatests/com/google/dart/compiler/resolver/ResolverAuditVisitor.java b/compiler/javatests/com/google/dart/compiler/resolver/ResolverAuditVisitor.java
index e3bdcf7476f4ec489f176d7f1883f015628f0d92..50d1557ea04d3ce3e110c1c0fbad24fe1307baa3 100644
--- a/compiler/javatests/com/google/dart/compiler/resolver/ResolverAuditVisitor.java
+++ b/compiler/javatests/com/google/dart/compiler/resolver/ResolverAuditVisitor.java
@@ -18,7 +18,7 @@ import com.google.dart.compiler.ast.DartTypeParameter;
import java.util.List;
/**
- * Look for DartIdentifier nodes in the tree whose symbols are null. They should all either
+ * Look for DartIdentifier nodes in the tree whose elements are null. They should all either
* be resolved, or marked as an unresolved element.
*/
public class ResolverAuditVisitor extends ASTVisitor<Void> {
@@ -27,7 +27,7 @@ public class ResolverAuditVisitor extends ASTVisitor<Void> {
root.accept(visitor);
List<String> results = visitor.getFailures();
if (results.size() > 0) {
- StringBuilder out = new StringBuilder("Missing symbols found in AST\n");
+ StringBuilder out = new StringBuilder("Missing elements found in AST\n");
Joiner.on("\n").appendTo(out, results);
ResolverTestCase.fail(out.toString());
}
@@ -48,8 +48,8 @@ public class ResolverAuditVisitor extends ASTVisitor<Void> {
@Override
public Void visitIdentifier(DartIdentifier node) {
- if (node.getSymbol() == null) {
- failures.add("Identifier: " + node.getTargetName() + " has null symbol @ ("
+ if (node.getElement() == null) {
+ failures.add("Identifier: " + node.getName() + " has null element @ ("
+ node.getSourceLine() + ":" + node.getSourceColumn() + ")");
}
return null;

Powered by Google App Engine
This is Rietveld 408576698