Issue 9632019: Fix whitespace, long lines, and "boolean".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9632019: Fix whitespace, long lines, and "boolean". (Closed)

Created:
8 years, 9 months ago by Bill Hesse

Modified:
8 years, 9 months ago

Reviewers:
zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix whitespace, long lines, and "boolean". BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5225

Patch Set 2 : Fix indentation #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -40 lines)			Patch
M	tools/testing/dart/multitest.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/testing/dart/test_options.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/testing/dart/test_progress.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/testing/dart/test_runner.dart	View		14 chunks	+20 lines, -20 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1	8 chunks	+13 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

https://chromiumcodereview.appspot.com/9632019/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://chromiumcodereview.appspot.com/9632019/diff/1/tools/testing/dart/test_suite.dart#newcode669 tools/testing/dart/test_suite.dart:669: Strings.join(generatedTestPath, '/')); Indent 4, not 2.

8 years, 9 months ago (2012-03-08 12:33:26 UTC) #1

zundel

8 years, 9 months ago (2012-03-08 18:50:34 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/9632019/diff/1/tools/testing/dart/test...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/9632019/diff/1/tools/testing/dart/test...
tools/testing/dart/test_suite.dart:669: Strings.join(generatedTestPath, '/'));
On 2012/03/08 12:33:26, Bill Hesse wrote:
> Indent 4, not 2.
OK (but its still 2)

Expand Messages | Collapse Messages

Issue 9632019: Fix whitespace, long lines, and "boolean". (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix indentation #

Messages