Fix whitespace, long lines, and "boolean".

tools/testing/dart/test_suite.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for enumerating and preparing tests.
  *
  * This library includes:
  *
  * - Creating tests by listing all the Dart files in certain directories,
@@ skipping 159 matching lines @@
 }
 
 
 class TestInformation {
   String filename;
   Map optionsFromFile;
   bool isNegative;
   bool isNegativeIfChecked;
   bool hasFatalTypeErrors;
   bool hasRuntimeErrors;
-  // expected outcome from multi-test  "static type error", "compile-time error", etc
   String multitestOutcome;
 
   TestInformation(this.filename, this.optionsFromFile, this.isNegative,
                   this.isNegativeIfChecked, this.hasFatalTypeErrors,
                   this.hasRuntimeErrors, this.multitestOutcome);
 }
 
 /**
  * A standard [TestSuite] implementation that searches for tests in a
  * directory, and creates [TestCase]s that compile and/or run them.
@@ skipping 443 matching lines @@
 
     // Create '[build dir]/generated_tests/$component/$testUniqueName',
       // including any intermediate directories that don't exist.
     var generatedTestPath = ['generated_tests',
                              configuration['component'],
                              testUniqueName];
 
     String tempDirPath = TestUtils.buildDir(configuration);
     if (requiresCleanTemporaryDirectory) {
       tempDirPath = globalTemporaryDirectory();
-      String debugMode = 
+      String debugMode =
           (configuration['mode'] == 'debug') ? 'Debug_' : 'Release_';
       generatedTestPath = ['${debugMode}_${configuration["arch"]}']
           .addAll(generatedTestPath);
     }
     Directory tempDir = new Directory(tempDirPath);
     if (!tempDir.existsSync()) {
       // Dartium tests can be run with no build step, with no output directory.
       // This special case builds the build directory that should be there.
       var buildPath = tempDirPath.split('/');
       tempDirPath = buildPath[0];
       if (tempDirPath == '') {
         throw new Exception(
             'Non-relative path to build directory in test_suite.dart');
       }
       buildPath.removeRange(0, 1);
       if (buildPath.last() == '') buildPath.removeLast();
       buildPath.addAll(generatedTestPath);
       generatedTestPath = buildPath;
       tempDir = new Directory(tempDirPath);
       if (!tempDir.existsSync()) {
         tempDir.createSync();
       }
     }
     tempDirPath = new File(tempDirPath).fullPathSync().replaceAll('\\', '/');
-    return TestUtils.mkdirRecursive(tempDirPath, 
+    return TestUtils.mkdirRecursive(tempDirPath,
       Strings.join(generatedTestPath, '/'));

[Bill Hesse, 2012/03/08 12:33:26]

Indent 4, not 2.

[zundel, 2012/03/08 18:50:34]

OK (but its still 2)

   }
 
   String get scriptType() {
     switch (configuration['component']) {
       case 'dartium':
         return 'application/dart';
       case 'chromium':
       case 'frogium':
       case 'legium':
       case 'webdriver':
@@ skipping 77 matching lines @@
     }
 
     return result;
   }
 
   Map readOptionsFromFile(String filename) {
     RegExp testOptionsRegExp = const RegExp(@"// VMOptions=(.*)");
     RegExp dartOptionsRegExp = const RegExp(@"// DartOptions=(.*)");
     RegExp otherScriptsRegExp = const RegExp(@"// OtherScripts=(.*)");
     RegExp multiTestRegExp = const RegExp(@"/// [0-9][0-9]:(.*)");
-    RegExp staticTypeRegExp = const RegExp(@"/// ([0-9][0-9]:){0,1}\s*static type error");
-    RegExp compileTimeRegExp = const RegExp(@"/// ([0-9][0-9]:){0,1}\s*compile-time error");
+    RegExp staticTypeRegExp =
+        const RegExp(@"/// ([0-9][0-9]:){0,1}\s*static type error");
+    RegExp compileTimeRegExp =
+        const RegExp(@"/// ([0-9][0-9]:){0,1}\s*compile-time error");
     RegExp staticCleanRegExp = const RegExp(@"// @static-clean");
     RegExp leadingHashRegExp = const RegExp(@"^#", multiLine: true);
     RegExp isolateStubsRegExp = const RegExp(@"// IsolateStubs=(.*)");
     RegExp domImportRegExp =
         const RegExp(@"^#import.*(dart:(dom|html)|html\.dart).*\)",
                      multiLine: true);
     RegExp libraryDefinitionRegExp =
         const RegExp(@"^#library\(", multiLine: true);
     RegExp sourceOrImportRegExp =
         const RegExp(@"^#(source|import)\(", multiLine: true);
@@ skipping 33 matching lines @@
     }
 
     matches = staticCleanRegExp.allMatches(contents);
     for (var match in matches) {
       if (isStaticClean) {
         throw new Exception(
             'More than one "// @static-clean=" line in test $filename');
       }
       isStaticClean = true;
     }
-    
+
     List<String> otherScripts = new List<String>();
     matches = otherScriptsRegExp.allMatches(contents);
     for (var match in matches) {
       otherScripts.addAll(match[1].split(' ').filter((e) => e != ''));
     }
 
     if (contents.contains("@compile-error") ||
         contents.contains("@runtime-error")) {
       isNegative = true;
     }
-    
+
     bool isMultitest = multiTestRegExp.hasMatch(contents);
     bool containsLeadingHash = leadingHashRegExp.hasMatch(contents);
     Match isolateMatch = isolateStubsRegExp.firstMatch(contents);
     String isolateStubs = isolateMatch != null ? isolateMatch[1] : '';
     bool containsDomImport = domImportRegExp.hasMatch(contents);
     bool isLibraryDefinition = libraryDefinitionRegExp.hasMatch(contents);
     bool containsSourceOrImport = sourceOrImportRegExp.hasMatch(contents);
     int numStaticTypeAnnotations = 0;
     for (var i in staticTypeRegExp.allMatches(contents)) {
       numStaticTypeAnnotations++;
@@ skipping 182 matching lines @@
          '$dartDir/third_party/hamcrest/v1_3/hamcrest-generator-1.3.0RC2.jar',
          '$dartDir/third_party/hamcrest/v1_3/hamcrest-integration-1.3.0RC2.jar',
          '$dartDir/third_party/hamcrest/v1_3/hamcrest-library-1.3.0RC2.jar',
          '$dartDir/third_party/junit/v4_8_2/junit.jar'],
         ':');  // Path separator.
   }
 }
 
 
 class TestUtils {
-  
-  /** 
-   * Creates a directory using a [relativePath] to an existing 
+  /**
+   * Creates a directory using a [relativePath] to an existing
    * [base] directory if that [relativePath] does not already exist.
    */
   static Directory mkdirRecursive(String base, String relativePath) {
     Directory baseDir = new Directory(base);
     Expect.isTrue(baseDir.existsSync(),
-      "Expected ${base} to already exist");  
+      "Expected ${base} to already exist");
     var tempDir = new Directory(base);
     for (String dir in relativePath.split('/')) {
       base = "$base/$dir";
       tempDir = new Directory(base);
       if (!tempDir.existsSync()) {
           tempDir.createSync();
       }
       Expect.isTrue(tempDir.existsSync(), "Failed to create ${tempDir.path}");
     }
     return tempDir;
   }
 
   /**
    * Copy a [source] file to a new place.
    * Assumes that the directory for [dest] already exists.
    */
   static void copyFile(File source, File dest) {
     List contents = source.readAsBytesSync();
     RandomAccessFile handle = dest.openSync(FileMode.WRITE);
     handle.writeListSync(contents, 0, contents.length);
     handle.closeSync();
   }
-  
+
   static String executableSuffix(String component) {
     if (new Platform().operatingSystem() == 'windows') {
       if (component != 'frogium'
           && component != 'legium'
           && component != 'webdriver') {
         return '.exe';
       } else {
         return '.bat';
       }
     }
@@ skipping 137 matching lines @@
  * $noCrash tests are expected to be flaky but not crash
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
 """;
     print(report);
    }
 }