Issue 9624004: Allow any order for ExtAttrs and const in WebKit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9624004: Allow any order for ExtAttrs and const in WebKit. (Closed)

Created:
8 years, 9 months ago by antonm

Modified:
8 years, 9 months ago

Reviewers:
podivilov, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow any order for ExtAttrs and const in WebKit. ExtAttrs followed by const variant has been recently added into WebKit. Committed: https://code.google.com/p/dart/source/detail?r=5107

Patch Set 2 : Addressing Stephen's comments #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	client/dom/scripts/idlparser.py	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

antonm

The corresponding WebKit change: https://chromiumcodereview.appspot.com/9621004

8 years, 9 months ago (2012-03-07 15:12:20 UTC) #1

sra1

lgtm https://chromiumcodereview.appspot.com/9624004/diff/1/client/dom/scripts/idlparser.py File client/dom/scripts/idlparser.py (right): https://chromiumcodereview.appspot.com/9624004/diff/1/client/dom/scripts/idlparser.py#newcode147 client/dom/scripts/idlparser.py:147: [OR(['const', MAYBE(ExtAttrs)], [MAYBE(ExtAttrs), 'const']), Type, Id, '=', ConstExpr, ...

8 years, 9 months ago (2012-03-07 18:13:52 UTC) #2