Issue 9621004: Uncomment IDL fragments which we used to fail to parse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9621004: Uncomment IDL fragments which we used to fail to parse. (Closed)

Created:
8 years, 9 months ago by antonm

Modified:
8 years, 9 months ago

Reviewers:
podivilov, sra1

CC:
reviews+dom_dartlang.org

Base URL:
svn://svn.chromium.org/multivm/trunk/webkit

Visibility:
Public.

More Reviews

Description

Uncomment IDL fragments which we used to fail to parse. Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=233

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -9 lines)			Patch
	M	Source/WebCore/html/HTMLMediaElement.idl	View		1 chunk	+0 lines, -6 lines	1 comment	Download
	M	Source/WebCore/html/HTMLTrackElement.idl	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

antonm

The corresponding parser change: https://chromiumcodereview.appspot.com/9624004/

8 years, 9 months ago (2012-03-07 15:12:51 UTC) #1

sra1

8 years, 9 months ago (2012-03-07 18:42:31 UTC) #2

LGTM,

but when did the IDL change from
const [...] Foo
to
[...] const Foo

https://chromiumcodereview.appspot.com/9621004/diff/1/Source/WebCore/html/HTM...
File Source/WebCore/html/HTMLMediaElement.idl (right):

https://chromiumcodereview.appspot.com/9621004/diff/1/Source/WebCore/html/HTM...
Source/WebCore/html/HTMLMediaElement.idl:102:
[V8EnabledAtRuntime=webkitMediaSource] const unsigned short EOS_NO_ERROR = 0; //
End of stream reached w/o error.
The WekBit source seems to use const [ExtAttrs]
Why is this [ExtAttrs] const ?

Expand Messages | Collapse Messages