Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 9621004: Uncomment IDL fragments which we used to fail to parse. (Closed)

Created:
8 years, 9 months ago by antonm
Modified:
8 years, 9 months ago
Reviewers:
podivilov, sra1
CC:
reviews+dom_dartlang.org
Visibility:
Public.

Description

Uncomment IDL fragments which we used to fail to parse. Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=233

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M Source/WebCore/html/HTMLMediaElement.idl View 1 chunk +0 lines, -6 lines 1 comment Download
M Source/WebCore/html/HTMLTrackElement.idl View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
antonm
The corresponding parser change: https://chromiumcodereview.appspot.com/9624004/
8 years, 9 months ago (2012-03-07 15:12:51 UTC) #1
sra1
8 years, 9 months ago (2012-03-07 18:42:31 UTC) #2
LGTM,

but when did the IDL change from
const [...] Foo
to
[...] const Foo

https://chromiumcodereview.appspot.com/9621004/diff/1/Source/WebCore/html/HTM...
File Source/WebCore/html/HTMLMediaElement.idl (right):

https://chromiumcodereview.appspot.com/9621004/diff/1/Source/WebCore/html/HTM...
Source/WebCore/html/HTMLMediaElement.idl:102:
[V8EnabledAtRuntime=webkitMediaSource] const unsigned short EOS_NO_ERROR = 0; //
End of stream reached w/o error.
The WekBit source seems to use const [ExtAttrs]
Why is this [ExtAttrs] const ?

Powered by Google App Engine
This is Rietveld 408576698