Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9598002: Use ASTVisitor as in new AST. (Closed)

Created:
8 years, 9 months ago by scheglov
Modified:
8 years, 9 months ago
Reviewers:
zundel, Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use ASTVisitor as in new AST. I'm going to morph DartC to use new AST step by step. We need to have new AST, even with old parser, to easily switch later to the resilient parser and also for any other future work on refactoring, quick assists, etc. R=brianwilkerson@google.com,zundel@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4962

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+810 lines, -2910 lines) Patch
M compiler/java/com/google/dart/compiler/LibraryDepsVisitor.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + compiler/java/com/google/dart/compiler/ast/ASTVisitor.java View 4 chunks +14 lines, -97 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartArrayAccess.java View 1 chunk +2 lines, -11 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartArrayLiteral.java View 1 chunk +2 lines, -11 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartAssertion.java View 1 chunk +2 lines, -10 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartBinaryExpression.java View 1 chunk +2 lines, -15 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartBlock.java View 1 chunk +2 lines, -10 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartBooleanLiteral.java View 1 chunk +2 lines, -8 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartBreakStatement.java View 1 chunk +1 line, -10 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartCase.java View 1 chunk +2 lines, -11 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartCatchBlock.java View 2 chunks +2 lines, -14 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartClass.java View 2 chunks +2 lines, -22 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartClassMember.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartComment.java View 1 chunk +2 lines, -6 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartConditional.java View 1 chunk +2 lines, -11 lines 0 comments Download
D compiler/java/com/google/dart/compiler/ast/DartContext.java View 1 chunk +0 lines, -27 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartContinueStatement.java View 1 chunk +1 line, -10 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartDefault.java View 1 chunk +1 line, -9 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartDoWhileStatement.java View 1 chunk +2 lines, -11 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartDoubleLiteral.java View 1 chunk +2 lines, -8 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartEmptyStatement.java View 1 chunk +2 lines, -8 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartExprStmt.java View 1 chunk +2 lines, -9 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartField.java View 2 chunks +2 lines, -15 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartFieldDefinition.java View 2 chunks +2 lines, -13 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartForInStatement.java View 1 chunk +2 lines, -12 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartForStatement.java View 2 chunks +2 lines, -19 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartFunction.java View 2 chunks +2 lines, -15 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartFunctionExpression.java View 1 chunk +2 lines, -10 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartFunctionObjectInvocation.java View 1 chunk +2 lines, -11 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartFunctionTypeAlias.java View 2 chunks +2 lines, -14 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartGotoStatement.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartIdentifier.java View 1 chunk +2 lines, -8 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartIfStatement.java View 2 chunks +2 lines, -14 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartImportDirective.java View 2 chunks +2 lines, -13 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartInitializer.java View 2 chunks +2 lines, -15 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartIntegerLiteral.java View 1 chunk +2 lines, -8 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartLabel.java View 1 chunk +2 lines, -10 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartLibraryDirective.java View 1 chunk +2 lines, -10 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartMapLiteral.java View 1 chunk +2 lines, -11 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartMapLiteralEntry.java View 1 chunk +2 lines, -11 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartMethodDefinition.java View 2 chunks +3 lines, -20 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartMethodInvocation.java View 1 chunk +2 lines, -13 lines 0 comments Download
D compiler/java/com/google/dart/compiler/ast/DartModVisitor.java View 1 chunk +0 lines, -190 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartNamedExpression.java View 2 chunks +2 lines, -15 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartNativeBlock.java View 1 chunk +2 lines, -8 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartNativeDirective.java View 1 chunk +2 lines, -10 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartNewExpression.java View 1 chunk +2 lines, -11 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartNode.java View 2 chunks +4 lines, -4 lines 0 comments Download
D compiler/java/com/google/dart/compiler/ast/DartNodeTraverser.java View 1 chunk +0 lines, -442 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartNullLiteral.java View 1 chunk +2 lines, -8 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartParameter.java View 2 chunks +2 lines, -18 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartParameterizedTypeNode.java View 2 chunks +2 lines, -11 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartParenthesizedExpression.java View 1 chunk +2 lines, -10 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartPropertyAccess.java View 2 chunks +2 lines, -12 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartRedirectConstructorInvocation.java View 2 chunks +2 lines, -13 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartResourceDirective.java View 1 chunk +2 lines, -10 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartReturnStatement.java View 1 chunk +2 lines, -12 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartSourceDirective.java View 1 chunk +2 lines, -10 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartStringInterpolation.java View 1 chunk +2 lines, -11 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartStringLiteral.java View 1 chunk +2 lines, -8 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartSuperConstructorInvocation.java View 2 chunks +2 lines, -13 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartSuperExpression.java View 1 chunk +2 lines, -8 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartSwitchMember.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartSwitchStatement.java View 1 chunk +2 lines, -11 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartSyntheticErrorExpression.java View 2 chunks +2 lines, -8 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartSyntheticErrorStatement.java View 2 chunks +2 lines, -8 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartThisExpression.java View 1 chunk +2 lines, -8 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartThrowStatement.java View 1 chunk +2 lines, -12 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java View 28 chunks +160 lines, -148 lines 2 comments Download
M compiler/java/com/google/dart/compiler/ast/DartTryStatement.java View 2 chunks +2 lines, -14 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartTypeExpression.java View 1 chunk +2 lines, -10 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartTypeNode.java View 1 chunk +2 lines, -11 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartTypeParameter.java View 1 chunk +2 lines, -12 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartTypedLiteral.java View 1 chunk +1 line, -8 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartUnaryExpression.java View 1 chunk +2 lines, -14 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartUnit.java View 6 chunks +3 lines, -31 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartUnqualifiedInvocation.java View 1 chunk +2 lines, -11 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartVariable.java View 1 chunk +2 lines, -12 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartVariableStatement.java View 2 chunks +2 lines, -13 lines 0 comments Download
D compiler/java/com/google/dart/compiler/ast/DartVisitable.java View 1 chunk +0 lines, -19 lines 0 comments Download
D compiler/java/com/google/dart/compiler/ast/DartVisitor.java View 1 chunk +0 lines, -622 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartWhileStatement.java View 1 chunk +2 lines, -11 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/viz/BaseASTWriter.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/CommentPreservingParser.java View 3 chunks +3 lines, -3 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java View 3 chunks +3 lines, -3 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantResolver.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/ResolveVisitor.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 4 chunks +4 lines, -5 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/CompilerTestCase.java View 3 chunks +3 lines, -3 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/DartASTValidator.java View 14 chunks +70 lines, -71 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/ParserRoundTripTest.java View 2 chunks +1 line, -5 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java View 1 chunk +2 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/ResolverAuditVisitor.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/completion/CompletionMetrics.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/NodeFinder.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyGetter.java View 3 chunks +3 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyLocator.java View 13 chunks +12 lines, -9 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertySetter.java View 3 chunks +3 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyVisitor.java View 3 chunks +2 lines, -25 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/visitor/ChildVisitor.java View 3 chunks +5 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/visitor/SafeDartNodeTraverser.java View 1 chunk +7 lines, -8 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/visitor/WrappedDartVisitor.java View 1 chunk +6 lines, -4 lines 2 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/visitor/WrappedDartVisitorAdaptor.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/ErrorChecker.java View 1 chunk +2 lines, -2 lines 2 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java View 5 chunks +5 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ScopedNameFinder.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/TypeRefiner.java View 2 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/dom/rewrite/ASTRewriteAnalyzer.java View 5 chunks +5 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/formatter/BinaryExpressionFragmentBuilder.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/formatter/CascadingInvocationFragmentBuilder.java View 1 chunk +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/formatter/CodeFormatterVisitor.java View 3 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/index/contributor/IndexContributor.java View 2 chunks +2 lines, -2 lines 0 comments Download
D editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/indexer/contributor/AbstractDartContributor.java View 1 chunk +0 lines, -310 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/indexer/contributor/DartContributor.java View 2 chunks +284 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/indexer/contributor/ElementsByCategoryContributor.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/indexer/contributor/MethodOverrideContributor.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/indexer/contributor/ScopedDartContributor.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/indexer/contributor/TypeHierarchyContributor.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/CompilationUnitImpl.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/util/DOMFinder.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/NameOccurrencesFinder.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/callhierarchy/CalleeAnalyzerVisitor.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/SelectionAnalyzer.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/NodeClassifier.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/OverrideIndicatorManager.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/SemanticHighlightingReconciler.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/selectionactions/StructureSelectNextAction.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/selectionactions/StructureSelectPreviousAction.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
8 years, 9 months ago (2012-03-05 16:17:55 UTC) #1
Brian Wilkerson
LGTM, although it would be nice to split changes like these into smaller CL's in ...
8 years, 9 months ago (2012-03-05 16:57:34 UTC) #2
scheglov
Yes, I'd like to make smaller CLs, but unfortunately with changes like this you have ...
8 years, 9 months ago (2012-03-05 17:22:51 UTC) #3
zundel
8 years, 9 months ago (2012-03-05 17:25:23 UTC) #4 
dartc changes LGTM

On 2012/03/05 17:22:51, scheglov wrote:
> Yes, I'd like to make smaller CLs, but unfortunately with changes like this
you
> have "all or nothing". I have to change all DartNode subclasses, and rename
also
> changes all places.
> 
> Also, to work in 2012Q2 on AST transformations - refactoring, rewrite, quick
> assists, I'd like to have new AST in place to avoid reworking these parts
later.
> 
>
https://chromiumcodereview.appspot.com/9598002/diff/1/compiler/java/com/googl...
> File compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java
> (right):
> 
>
https://chromiumcodereview.appspot.com/9598002/diff/1/compiler/java/com/googl...
> compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java:257: {
> On 2012/03/05 16:57:35, Brian Wilkerson wrote:
> > nit: it would be easier to read if we remove the extraneous block.
> 
> Done.
> 
>
https://chromiumcodereview.appspot.com/9598002/diff/1/editor/tools/plugins/co...
> File
>
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/visitor/WrappedDartVisitor.java
> (right):
> 
>
https://chromiumcodereview.appspot.com/9598002/diff/1/editor/tools/plugins/co...
>
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/visitor/WrappedDartVisitor.java:20:
> * The interface <code>WrappedDartVisitor</code> defines the behavior of a
> visitor that implements
> On 2012/03/05 16:57:35, Brian Wilkerson wrote:
> > nit: "interface" -> "class"
> 
> Done.
> 
>
https://chromiumcodereview.appspot.com/9598002/diff/1/editor/tools/plugins/co...
> File
>
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/ErrorChecker.java
> (right):
> 
>
https://chromiumcodereview.appspot.com/9598002/diff/1/editor/tools/plugins/co...
>
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/ErrorChecker.java:19:
> * The interface <code>ErrorChecker</code> defines the behavior of objects that
> can be used to check
> On 2012/03/05 16:57:35, Brian Wilkerson wrote:
> > nit: "interface" -> "class"
> 
> Done.

Powered by Google App Engine
This is Rietveld 408576698