Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyVisitor.java

Issue 9598002: Use ASTVisitor as in new AST. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyVisitor.java
diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyVisitor.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyVisitor.java
index e55e442a4e21f000d05bf942ed70f1d61fb15ef1..ddf230c16393a023a4e78230582e45eda3e1d151 100644
--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyVisitor.java
+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyVisitor.java
@@ -13,15 +13,8 @@
*/
package com.google.dart.tools.core.dom;
-import com.google.dart.compiler.ast.DartClassMember;
-import com.google.dart.compiler.ast.DartExpression;
-import com.google.dart.compiler.ast.DartGotoStatement;
-import com.google.dart.compiler.ast.DartInvocation;
-import com.google.dart.compiler.ast.DartLiteral;
import com.google.dart.compiler.ast.DartNode;
-import com.google.dart.compiler.ast.DartPlainVisitor;
-import com.google.dart.compiler.ast.DartStatement;
-import com.google.dart.compiler.ast.DartSwitchMember;
+import com.google.dart.compiler.ast.ASTVisitor;
import java.util.List;
@@ -29,7 +22,7 @@ import java.util.List;
* The abstract class <code>PropertyVisitor</code> implements behavior common to visitors that
* traverse the type hierarchy in order to manipulate the properties of a node.
*/
-public abstract class PropertyVisitor implements DartPlainVisitor<Object> {
+public abstract class PropertyVisitor extends ASTVisitor<Object> {
/**
* The specification of the property being manipulated.
*/
@@ -53,22 +46,6 @@ public abstract class PropertyVisitor implements DartPlainVisitor<Object> {
}
}
- public abstract <N extends DartExpression> Object visitClassMember(DartClassMember<N> node);
-
- public abstract Object visitExpression(DartExpression node);
-
- public abstract Object visitGotoStatement(DartGotoStatement node);
-
- public abstract Object visitInvocation(DartInvocation node);
-
- public abstract Object visitLiteral(DartLiteral node);
-
- public abstract Object visitNode(DartNode node);
-
- public abstract Object visitStatement(DartStatement node);
-
- public abstract Object visitSwitchMember(DartSwitchMember node);
-
protected void noSuchProperty(String nodeClassName) {
throw new RuntimeException("No property named " + property.getId()
+ " defined for instances of " + nodeClassName);

Powered by Google App Engine
This is Rietveld 408576698