Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 9580036: - Always write a Null Object for Code objects (Closed)

Created:
8 years, 9 months ago by siva
Modified:
8 years, 9 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Always write a Null Object for Code objects - Do not populate the FunctionsCache array as it causes the function cache to become inconsistent if we execute some dart code before capturing a snapshot. - Allow preallocation of objects even when generating snapshot and remove the flag preallocate_objects_called_ (use a null test instead). Committed: https://code.google.com/p/dart/source/detail?r=4915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -31 lines) Patch
M vm/code_generator.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M vm/dart_api_impl.cc View 1 chunk +12 lines, -14 lines 0 comments Download
M vm/object_store.h View 1 chunk +0 lines, -2 lines 0 comments Download
M vm/object_store.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M vm/raw_object_snapshot.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M vm/snapshot.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
siva
8 years, 9 months ago (2012-03-03 00:37:50 UTC) #1
Ivan Posva
8 years, 9 months ago (2012-03-03 00:48:59 UTC) #2
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698