Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: vm/raw_object_snapshot.cc

Issue 9580036: - Always write a Null Object for Code objects (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/object_store.cc ('k') | vm/snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/raw_object_snapshot.cc
===================================================================
--- vm/raw_object_snapshot.cc (revision 4911)
+++ vm/raw_object_snapshot.cc (working copy)
@@ -866,12 +866,9 @@
void RawCode::WriteTo(SnapshotWriter* writer,
intptr_t object_id,
Snapshot::Kind kind) {
- // Currently we do not serialize any code and hence we write
- // out a null object for it.
- ASSERT(writer != NULL);
- ASSERT(kind != Snapshot::kMessage);
-
- writer->WriteIndexedObject(Object::kNullObject);
+ // We have already checked for this and written a NULL object, hence we
+ // should not reach here.
+ UNREACHABLE();
}
@@ -1909,7 +1906,7 @@
intptr_t object_id,
intptr_t tags,
Snapshot::Kind kind) {
- UNIMPLEMENTED();
+ UNREACHABLE();
return NULL;
}
@@ -1917,7 +1914,7 @@
void RawICData::WriteTo(SnapshotWriter* writer,
intptr_t object_id,
Snapshot::Kind kind) {
- UNIMPLEMENTED();
+ UNREACHABLE();
}
« no previous file with comments | « vm/object_store.cc ('k') | vm/snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698