Issue 9567032: Bring htmlconverter back up to date:

Issue 9567032: Bring htmlconverter back up to date: (Closed)

Created:
8 years, 9 months ago by vsm

Modified:
8 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Bring htmlconverter back up to date: - Remove dartc path. - Use dom or html for DOMContentLoaded depending on the compiled source. - Fix up tests. Committed: https://code.google.com/p/dart/source/detail?r=4851

Patch Set 1 #

Total comments: 3

Patch Set 2 : change update.py as well #

Patch Set 3 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -82 lines)			Patch
M	client/tools/htmlconverter.py	View		12 chunks	+44 lines, -61 lines	0 comments	Download
M	client/tools/htmlconverter_test.py	View		6 chunks	+5 lines, -6 lines	0 comments	Download
M	client/tools/update.py	View	1	3 chunks	+1 line, -14 lines	0 comments	Download
M	samples/third_party/dromaeo/generate_frog_tests.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

we need to also fix client/tools/update.py which imports and invokes convertForChromium/ https://chromiumcodereview.appspot.com/9567032/diff/1/client/tools/htmlconverter.py File client/tools/htmlconverter.py (right): ...

8 years, 9 months ago (2012-03-02 01:21:16 UTC) #2

vsm

https://chromiumcodereview.appspot.com/9567032/diff/1/client/tools/htmlconverter.py File client/tools/htmlconverter.py (right): https://chromiumcodereview.appspot.com/9567032/diff/1/client/tools/htmlconverter.py#newcode180 client/tools/htmlconverter.py:180: 'frog', 'bin', 'frogsh')) Using out/Release_ia32/frog/bin/frog doesn't work. The file ...

8 years, 9 months ago (2012-03-02 01:53:56 UTC) #3

Siggi Cherem (dart-lang)

8 years, 9 months ago (2012-03-02 02:01:06 UTC) #4

lgtm, thanks!

https://chromiumcodereview.appspot.com/9567032/diff/1/client/tools/htmlconver...
File client/tools/htmlconverter.py (right):

https://chromiumcodereview.appspot.com/9567032/diff/1/client/tools/htmlconver...
client/tools/htmlconverter.py:180: 'frog', 'bin', 'frogsh'))
On 2012/03/02 01:53:56, vsm wrote:
> Using out/Release_ia32/frog/bin/frog doesn't work.  The file exists, but I get
> an error when running.
> 
> On 2012/03/02 01:21:16, sigmund wrote:
> > might be better to use frog, rather than frogsh by default (that way you
won't
> > need node installed)
> 

Ok - we can keep it as is, and later try to fix the issues with paths in
release/frog

Expand Messages | Collapse Messages