Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: client/tools/update.py

Issue 9567032: Bring htmlconverter back up to date: (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/tools/htmlconverter_test.py ('k') | samples/third_party/dromaeo/generate_frog_tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/tools/update.py
diff --git a/client/tools/update.py b/client/tools/update.py
index 364960bd3887c6054e64a2e77a21ba684ffef9d6..f73eec6e197dfb69c4e0d5e0e89174bc939e8ec9 100755
--- a/client/tools/update.py
+++ b/client/tools/update.py
@@ -25,11 +25,6 @@ def convertOne(infile, options):
outfile = join(outDirBase, infile)
print 'converting %s to %s' % (infile, outfile)
- # TODO(jmesserly): this is a workaround for an OOM error in DartC
- # See bug 5393264
- if options.optimize:
- os.putenv('DART_JVMARGS', '-Xmx512m')
-
if 'dart' in options.target:
htmlconverter.convertForDartium(
infile,
@@ -38,7 +33,7 @@ def convertOne(infile, options):
options.verbose)
if 'js' in options.target:
htmlconverter.convertForChromium(
- infile, options.optimize, options.frog, options.dartc_extra_flags,
+ infile, options.dartc_extra_flags,
outfile.replace('.html', '-js.html'),
options.verbose)
@@ -50,14 +45,6 @@ def Flags():
help="The target html to generate",
metavar="[js,dart]",
default='js,dart')
- result.add_option("--frog",
- help="Use frog compiler (default dartc)",
- default=False,
- action="store_true")
- result.add_option("--optimize",
- help="Use optimizer in dartc",
- default=False,
- action="store_true")
result.add_option("--verbose",
help="Print verbose output",
default=False,
« no previous file with comments | « client/tools/htmlconverter_test.py ('k') | samples/third_party/dromaeo/generate_frog_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698