Add missing includes (spotted while splitting cpp derived sources).

Add missing includes (spotted while splitting cpp derived sources).

Corresponding WebKit change: https://chromiumcodereview.appspot.com/9570007.

R=antonm@chromium.org

Committed: https://code.google.com/p/dart/source/detail?r=4800

[antonm, 2012-03-01 14:25:31]

https://chromiumcodereview.appspot.com/9565006/diff/1/client/dom/scripts/gene...
File client/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/9565006/diff/1/client/dom/scripts/gene...
client/dom/scripts/generator.py:492: if self._idl_type == 'SVGNumber' or
self._idl_type == 'SVGPoint':
maybe, as you're touching it anyway, self._idl_type in ['SVGNumber', 'SVGPoint']

https://chromiumcodereview.appspot.com/9565006/diff/1/client/dom/scripts/gene...
client/dom/scripts/generator.py:496:
includes.append(self._idl_type.replace('Abs', '').replace('Rel', ''))
maybe make it additional_include = self._idl_type.replace(

and then

return includes + [additional_include]

https://chromiumcodereview.appspot.com/9565006/diff/1/client/dom/scripts/syst...
File client/dom/scripts/systemnative.py (right):

https://chromiumcodereview.appspot.com/9565006/diff/1/client/dom/scripts/syst...
client/dom/scripts/systemnative.py:82:
cpp_impl_includes[argument_type_info.conversion_include()] = 1
why it's map?  should we assign 1 or None?

https://chromiumcodereview.appspot.com/9565006/diff/1/client/dom/scripts/syst...
client/dom/scripts/systemnative.py:171: cpp_all_in_one_path =
os.path.join(self._output_dir,
cpp_all_in_one is now misleading

https://chromiumcodereview.appspot.com/9565006/diff/1/client/dom/scripts/syst...
client/dom/scripts/systemnative.py:175: for j in range(i * sources_count /
partitions, (i + 1) * sources_count / partitions):
for impl_file in self._cpp_impl_files[i * sources_count / partitions : (i + 1) *
sources_count / partitions]:  ?

or, as you probably do not care about exact set of included sources:

for impl_file in self._cpp_impl_files[i::partitiions]"

https://chromiumcodereview.appspot.com/9565006/diff/1/client/dom/scripts/syst...
client/dom/scripts/systemnative.py:797: return ''.join(['#include "%s.h"\n' % i
for i in includes])
nit: i is usually for index :)

[podivilov, 2012-03-01 15:36:56]

http://codereview.chromium.org/9565006/diff/1/client/dom/scripts/generator.py
File client/dom/scripts/generator.py (right):

http://codereview.chromium.org/9565006/diff/1/client/dom/scripts/generator.py...
client/dom/scripts/generator.py:492: if self._idl_type == 'SVGNumber' or
self._idl_type == 'SVGPoint':
On 2012/03/01 14:25:31, antonm wrote:
> maybe, as you're touching it anyway, self._idl_type in ['SVGNumber',
'SVGPoint']
> 

Done.

http://codereview.chromium.org/9565006/diff/1/client/dom/scripts/generator.py...
client/dom/scripts/generator.py:496:
includes.append(self._idl_type.replace('Abs', '').replace('Rel', ''))
On 2012/03/01 14:25:31, antonm wrote:
> maybe make it additional_include = self._idl_type.replace(
> 
> and then
> 
> return includes + [additional_include]

Done.

http://codereview.chromium.org/9565006/diff/1/client/dom/scripts/systemnative.py
File client/dom/scripts/systemnative.py (right):

http://codereview.chromium.org/9565006/diff/1/client/dom/scripts/systemnative...
client/dom/scripts/systemnative.py:82:
cpp_impl_includes[argument_type_info.conversion_include()] = 1
On 2012/03/01 14:25:31, antonm wrote:
> why it's map?  should we assign 1 or None?

Done.

http://codereview.chromium.org/9565006/diff/1/client/dom/scripts/systemnative...
client/dom/scripts/systemnative.py:175: for j in range(i * sources_count /
partitions, (i + 1) * sources_count / partitions):
On 2012/03/01 14:25:31, antonm wrote:
> for impl_file in self._cpp_impl_files[i * sources_count / partitions : (i + 1)
*
> sources_count / partitions]:  ?
> 
> or, as you probably do not care about exact set of included sources:
> 
> for impl_file in self._cpp_impl_files[i::partitiions]"

nice!

http://codereview.chromium.org/9565006/diff/1/client/dom/scripts/systemnative...
client/dom/scripts/systemnative.py:797: return ''.join(['#include "%s.h"\n' % i
for i in includes])
On 2012/03/01 14:25:31, antonm wrote:
> nit: i is usually for index :)

Done.

[antonm, 2012-03-01 15:44:50]

LGTM

http://codereview.chromium.org/9565006/diff/3001/client/dom/scripts/systemnat...
File client/dom/scripts/systemnative.py (right):

http://codereview.chromium.org/9565006/diff/3001/client/dom/scripts/systemnat...
client/dom/scripts/systemnative.py:81: cpp_impl_includes |=
set(argument_type_info.conversion_includes())
or cpp_impl_includes.update(argument_type_info.conversion_includes())

http://codereview.chromium.org/9565006/diff/3001/client/dom/scripts/systemnat...
client/dom/scripts/systemnative.py:178: cpp_all_in_one_emitter =
self._emitters.FileEmitter(derived_sources_path)
cpp_all_in_one, cpp_all_in_one, la-la

http://codereview.chromium.org/9565006/diff/3001/client/dom/scripts/systemnat...
client/dom/scripts/systemnative.py:744: self._cpp_impl_includes |=
set(return_type_info.conversion_includes())
ditto