Issue 9570007: Split Dart derived cpp sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9570007: Split Dart derived cpp sources. (Closed)

Created:
8 years, 9 months ago by podivilov

Modified:
8 years, 9 months ago

Reviewers:
antonm

CC:
reviews+dom_dartlang.org

Base URL:
svn://svn.chromium.org/multivm/trunk/webkit

Visibility:
Public.

More Reviews

Description

Split Dart derived cpp sources. R=antonm@chromium.org Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=205

Patch Set 2 : . #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -22 lines)			Patch
	M	Source/WebCore/bindings/dart/gyp/dartium.gyp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/WebCore/bindings/dart/gyp/overrides.gypi	View		1 chunk	+20 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

antonm

neat and thanks https://chromiumcodereview.appspot.com/9570007/diff/1/Source/WebCore/bindings/dart/gyp/dartium.gyp File Source/WebCore/bindings/dart/gyp/dartium.gyp (left): https://chromiumcodereview.appspot.com/9570007/diff/1/Source/WebCore/bindings/dart/gyp/dartium.gyp#oldcode325 Source/WebCore/bindings/dart/gyp/dartium.gyp:325: '<(output_path)/DartResolver.cpp', why resolver has gone?

8 years, 9 months ago (2012-03-01 14:15:24 UTC) #2

podivilov

PTAL http://codereview.chromium.org/9570007/diff/1/Source/WebCore/bindings/dart/gyp/dartium.gyp File Source/WebCore/bindings/dart/gyp/dartium.gyp (left): http://codereview.chromium.org/9570007/diff/1/Source/WebCore/bindings/dart/gyp/dartium.gyp#oldcode325 Source/WebCore/bindings/dart/gyp/dartium.gyp:325: '<(output_path)/DartResolver.cpp', On 2012/03/01 14:15:25, antonm wrote: > why ...

8 years, 9 months ago (2012-03-01 14:20:03 UTC) #3

sweeeeeeet  LGTM

Expand Messages | Collapse Messages

Issue 9570007: Split Dart derived cpp sources. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Messages