Issue 9562045: Added stack overflow checks at backward branches in order to allow interrupting endless loops. Bett…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9562045: Added stack overflow checks at backward branches in order to allow interrupting endless loops. Bett… (Closed)

Created:
8 years, 9 months ago by srdjan

Modified:
8 years, 9 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Added stack overflow checks at backward branches in order to allow interrupting endless loops. Better code will detect if the loop calready contains calls and therefore can omit the extra check (in next compiler). Committed: https://code.google.com/p/dart/source/detail?r=4889

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -7 lines)			Patch
M	runtime/vm/code_generator_ia32.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1	4 chunks	+18 lines, -0 lines	0 comments	Download
M	runtime/vm/code_generator_x64.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/code_generator_x64.cc	View	1 2	4 chunks	+18 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1	1 chunk	+1 line, -7 lines	0 comments	Download
M	runtime/vm/opt_code_generator_ia32.cc	View	1	3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/9562045/diff/1/runtime/vm/code_generator_x64.cc File runtime/vm/code_generator_x64.cc (right): https://chromiumcodereview.appspot.com/9562045/diff/1/runtime/vm/code_generator_x64.cc#newcode1809 runtime/vm/code_generator_x64.cc:1809: 0, Why do you pass kNoId and 0 ...

8 years, 9 months ago (2012-03-02 01:49:17 UTC) #2

srdjan

8 years, 9 months ago (2012-03-02 17:40:00 UTC) #3

https://chromiumcodereview.appspot.com/9562045/diff/1/runtime/vm/code_generat...
File runtime/vm/code_generator_x64.cc (right):

https://chromiumcodereview.appspot.com/9562045/diff/1/runtime/vm/code_generat...
runtime/vm/code_generator_x64.cc:1809: 0,
On 2012/03/02 01:49:17, regis wrote:
> Why do you pass kNoId and 0 instead of loop_id and token_index, as in the ia32
> version?
> I noticed other occurrences in several locations and 'fixed' them in the x64
> version in past cls. Should I not have?

My mistake, you have done it right.
Fixed.

Expand Messages | Collapse Messages