Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: runtime/vm/opt_code_generator_ia32.cc

Issue 9562045: Added stack overflow checks at backward branches in order to allow interrupting endless loops. Bett… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/opt_code_generator_ia32.cc
===================================================================
--- runtime/vm/opt_code_generator_ia32.cc (revision 4887)
+++ runtime/vm/opt_code_generator_ia32.cc (working copy)
@@ -2637,6 +2637,7 @@
}
}
node->body()->Visit(this);
+ HandleBackwardBranch(node->id(), node->token_index());
__ Bind(label->continue_label());
node->increment()->Visit(this);
__ jmp(&loop);
@@ -2654,6 +2655,7 @@
Label loop;
__ Bind(&loop);
node->body()->Visit(this);
+ HandleBackwardBranch(node->id(), node->token_index());
__ Bind(label->continue_label());
CodeGenInfo condition_info(node->condition());
condition_info.set_false_label(label->break_label());
@@ -2693,6 +2695,7 @@
__ j(NOT_EQUAL, label->break_label());
}
node->body()->Visit(this);
+ HandleBackwardBranch(node->id(), node->token_index());
__ jmp(label->continue_label());
__ Bind(label->break_label());
}
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698