Adding Native Call node : a native function consists of that node, it does call into C runtime. In …

Adding Native Call node : a native function consists of that node, it does call into C runtime. In this case I am not sure if we should copy all fields from AstNode to Computation node or should we store the AstNode and access data indirectly.
Committed: https://code.google.com/p/dart/source/detail?r=4809

[srdjan, 2012-03-01 01:08:16]

This CL also includes the yet uncommited CL 9540008

[Kevin Millikin (Google), 2012-03-01 09:26:22]

LGTM, with one suggestion below (print formatting).

https://chromiumcodereview.appspot.com/9559012/diff/4001/runtime/vm/flow_grap...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/9559012/diff/4001/runtime/vm/flow_grap...
runtime/vm/flow_graph_builder.cc:707: OS::Print("NativeCall '%s'",
comp->native_name().ToCString());
For uniformity this should probably print as

NativeCall(%s)

(I don't care too much about the actual print representation, as long as it's
uniform.)

https://chromiumcodereview.appspot.com/9559012/diff/4001/runtime/vm/intermedi...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/9559012/diff/4001/runtime/vm/intermedi...
runtime/vm/intermediate_language.h:18: class NativeBodyNode;
Do you want both the include of ast.h and the forward declaration?  I'd probably
GC the forward declaration.

https://chromiumcodereview.appspot.com/9559012/diff/4001/runtime/vm/intermedi...
runtime/vm/intermediate_language.h:246: explicit NativeCallComp(NativeBodyNode*
node) : ast_node_(*node) {}
I think this is fine to store the AST node and forward accessors to it.  I would
do the same here.

It would also be OK to do something similar for InstanceCallComp and
StaticCallComp, but it doesn't seem there is always a StaticCallNode or
InstanceCallNode in those cases, and creating one for the IL seems wrong.

[srdjan, 2012-03-01 17:25:42]

https://chromiumcodereview.appspot.com/9559012/diff/4001/runtime/vm/flow_grap...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/9559012/diff/4001/runtime/vm/flow_grap...
runtime/vm/flow_graph_builder.cc:707: OS::Print("NativeCall '%s'",
comp->native_name().ToCString());
On 2012/03/01 09:26:22, kmillikin wrote:
> For uniformity this should probably print as
> 
> NativeCall(%s)
> 
> (I don't care too much about the actual print representation, as long as it's
> uniform.)

Done.

https://chromiumcodereview.appspot.com/9559012/diff/4001/runtime/vm/intermedi...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/9559012/diff/4001/runtime/vm/intermedi...
runtime/vm/intermediate_language.h:18: class NativeBodyNode;
On 2012/03/01 09:26:22, kmillikin wrote:
> Do you want both the include of ast.h and the forward declaration?  I'd
probably
> GC the forward declaration.

Forgot to remove. Removed.