Adding Native Call node : a native function consists of that node, it does call into C runtime. In …

runtime/vm/intermediate_language.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_INTERMEDIATE_LANGUAGE_H_
 #define VM_INTERMEDIATE_LANGUAGE_H_
 
 #include "vm/allocation.h"
+#include "vm/ast.h"
 #include "vm/growable_array.h"
 #include "vm/handles_impl.h"
 #include "vm/object.h"
 
 namespace dart {
 
 class FlowGraphVisitor;
 class LocalVariable;
+class NativeBodyNode;

[Kevin Millikin (Google), 2012/03/01 09:26:22]

Do you want both the include of ast.h and the forward declaration?  I'd probably
GC the forward declaration.

[srdjan, 2012/03/01 17:25:42]

Forgot to remove. Removed.

 
 // Computations and values.
 //
 // <Computation> ::= <Value>
 //                 | AssertAssignable <Value> <AbstractType>
 //                 | InstanceCall <cstring> <Value> ...
 //                 | StaticCall <Function> <Value> ...
 //                 | LoadLocal <LocalVariable>
 //                 | StoreLocal <LocalVariable> <Value>
 //                 | StrictCompare <Token::kind> <Value> <Value>
+//                 | NativeCall <String> <NativeFunction> <int> <bool>
 //
 // <Value> ::= Temp <int>
 //           | Constant <Instance>
 
 // M is a two argument macro.  It is applied to each concrete value's
 // typename and classname.
 #define FOR_EACH_VALUE(M)                                                      \
   M(Temp, TempVal)                                                             \
   M(Constant, ConstantVal)
 
 // M is a two argument macro.  It is applied to each concrete instruction's
 // (including the values) typename and classname.
 #define FOR_EACH_COMPUTATION(M)                                                \
   FOR_EACH_VALUE(M)                                                            \
   M(AssertAssignable, AssertAssignableComp)                                    \
   M(InstanceCall, InstanceCallComp)                                            \
-  M(StrictCompare, StrictCompareComp)                                          \
   M(StaticCall, StaticCallComp)                                                \
   M(LoadLocal, LoadLocalComp)                                                  \
-  M(StoreLocal, StoreLocalComp)
+  M(StoreLocal, StoreLocalComp)                                                \
+  M(StrictCompare, StrictCompareComp)                                          \
+  M(NativeCall, NativeCallComp)                                                \
 
 
 #define FORWARD_DECLARATION(ShortName, ClassName) class ClassName;
 FOR_EACH_COMPUTATION(FORWARD_DECLARATION)
 #undef FORWARD_DECLARATION
 
 class Computation : public ZoneAllocated {
  public:
   Computation() { }
 
@@ skipping 172 matching lines @@
   const LocalVariable& local() const { return local_; }
   Value* value() const { return value_; }
 
  private:
   const LocalVariable& local_;
   Value* value_;
 
   DISALLOW_COPY_AND_ASSIGN(StoreLocalComp);
 };
 
+
+class NativeCallComp : public Computation {
+ public:
+  explicit NativeCallComp(NativeBodyNode* node) : ast_node_(*node) {}

[Kevin Millikin (Google), 2012/03/01 09:26:22]

I think this is fine to store the AST node and forward accessors to it.  I would
do the same here.

It would also be OK to do something similar for InstanceCallComp and
StaticCallComp, but it doesn't seem there is always a StaticCallNode or
InstanceCallNode in those cases, and creating one for the IL seems wrong.

+
+  DECLARE_COMPUTATION(NativeCall)
+
+  const String& native_name() const {
+    return ast_node_.native_c_function_name();
+  }
+
+ private:
+  const NativeBodyNode& ast_node_;
+
+  DISALLOW_COPY_AND_ASSIGN(NativeCallComp);
+};
+
 #undef DECLARE_COMPUTATION
 
 
 // Instructions.
 //
 // <Instruction> ::= Do <Computation> <Instruction>
 //                 | Bind <int> <Computation> <Instruction>
 //                 | Return <Value>
 //                 | Branch <Value> <Instruction> <Instruction>
 //                 | Empty <Instruction>
@@ skipping 258 matching lines @@
 #undef DECLARE_VISIT_INSTRUCTION
 
  private:
   DISALLOW_COPY_AND_ASSIGN(FlowGraphVisitor);
 };
 
 
 }  // namespace dart
 
 #endif  // VM_INTERMEDIATE_LANGUAGE_H_