Issue 9532001: This is the same change as r4644 (that was reverted in 4646), but I had quotes around the final %sc…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9532001: This is the same change as r4644 (that was reverted in 4646), but I had quotes around the final %sc… (Closed)

Created:
8 years, 9 months ago by Emily Fortuna

Modified:
8 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

This is the same change as r4644 (that was reverted in 4646), but I had quotes around the final %script% variable in the bat scripts that was causing arguments to be passed to frog incorrectly. Committed: https://code.google.com/p/dart/source/detail?r=4759

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -25 lines)			Patch
M	dart.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
D	frog/frogc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
D	frog/frogc.bat	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	frog/scripts/bootstrap/frog.bat	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	frog/scripts/bootstrap/frogc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	frog/scripts/bootstrap/frogc.bat	View	1 chunk	+1 line, -1 line	0 comments	Download
M	frog/scripts/bootstrap/frogsh.bat	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/create_sdk.py	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Here's the original CL for reference: https://chromiumcodereview.appspot.com//9465034

8 years, 9 months ago (2012-02-29 01:54:43 UTC) #1

lgtm

Expand Messages | Collapse Messages