Issue 9465034: Prettified Windows scripts and allowed Windows scripts to handle paths that have spaces. Also moved…

Issue 9465034: Prettified Windows scripts and allowed Windows scripts to handle paths that have spaces. Also moved… (Closed)

Created:
8 years, 10 months ago by Emily Fortuna

Modified:
8 years, 9 months ago

Reviewers:
dgrove

CC:
reviews_dartlang.org, kasperl

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Prettified Windows frog scripts and allowed Windows scripts to handle paths that have spaces. Also moved frogc to be with the other scripts. Addresses issues raised in Issue 1737. Committed: https://code.google.com/p/dart/source/detail?r=4644

Patch Set 1 : #

Total comments: 3

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -30 lines)			Patch
M	dart.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
D	frog/frogc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
D	frog/frogc.bat	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	frog/scripts/bootstrap/frog.bat	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	frog/scripts/bootstrap/frogc	View	0 chunks	+-1 lines, --1 lines	2 comments	Download
A +	frog/scripts/bootstrap/frogc.bat	View	1 chunk	+3 lines, -6 lines	1 comment	Download
M	frog/scripts/bootstrap/frogsh.bat	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/create_sdk.py	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

This addresses part of the issue here: http://code.google.com/p/dart/issues/detail?id=1737 https://chromiumcodereview.appspot.com/9465034/diff/2001/frog/scripts/bootstrap/frogc.bat File frog/scripts/bootstrap/frogc.bat (right): https://chromiumcodereview.appspot.com/9465034/diff/2001/frog/scripts/bootstrap/frogc.bat#newcode6 frog/scripts/bootstrap/frogc.bat:6: REM ...

8 years, 10 months ago (2012-02-25 01:18:02 UTC) #1

dgrove

lgtm https://chromiumcodereview.appspot.com/9465034/diff/2001/frog/scripts/bootstrap/frogc File frog/scripts/bootstrap/frogc (right): https://chromiumcodereview.appspot.com/9465034/diff/2001/frog/scripts/bootstrap/frogc#newcode7 frog/scripts/bootstrap/frogc:7: $SCRIPTPATH/dart --new_gen_heap_size=128 $SCRIPTPATH/frogc.dart --libdir=$LIBPATH $@ why is this ...

8 years, 10 months ago (2012-02-25 01:25:37 UTC) #2

Emily Fortuna

8 years, 10 months ago (2012-02-25 01:38:31 UTC) #3

https://chromiumcodereview.appspot.com/9465034/diff/2001/frog/scripts/bootstr...
File frog/scripts/bootstrap/frogc (right):

https://chromiumcodereview.appspot.com/9465034/diff/2001/frog/scripts/bootstr...
frog/scripts/bootstrap/frogc:7: $SCRIPTPATH/dart --new_gen_heap_size=128
$SCRIPTPATH/frogc.dart --libdir=$LIBPATH $@
On 2012/02/25 01:25:37, dgrove wrote:
> why is this file in the CL?

Since frogc seems to only be used for create_sdk, so I'm moving it to the same
location as frogc.bat. Do we want to keep it in the main frog directory as an
executable instead? I didn't think it was used outside of the sdk target...

Expand Messages | Collapse Messages