Do not go infinite loop if test fails constantly.

Do not go infinite loop if test fails constantly.

Committed: https://code.google.com/p/dart/source/detail?r=4704

[antonm, 2012-02-28 17:02:51]

Overall, are we sure we'd like to ignore the failure if DRT crashes?  It looks
like it can (and actually does) hide real failures.

[Mads Ager (google), 2012-02-28 17:06:55]

LGTM

I'll leave it to Emily and Bill to comment on the ignoring of DRT crashes. That
does look strange to me to but it might have been that way in the old python
scripts as well.

https://chromiumcodereview.appspot.com/9501003/diff/1/tools/testing/dart/test...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/9501003/diff/1/tools/testing/dart/test...
tools/testing/dart/test_runner.dart:288: print("Potential flake. Re-running
${testCase.displayName} (${testCase.dynamic.numRetries} remains)");
Long line.

[antonm, 2012-02-28 17:20:42]

Thanks a lot for review, Mads, submitting.

https://chromiumcodereview.appspot.com/9501003/diff/1/tools/testing/dart/test...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/9501003/diff/1/tools/testing/dart/test...
tools/testing/dart/test_runner.dart:288: print("Potential flake. Re-running
${testCase.displayName} (${testCase.dynamic.numRetries} remains)");
On 2012/02/28 17:06:56, Mads Ager wrote:
> Long line.

Done.  I am using + for now as "aa" "bb" syntax doesn't work for me right now.

[Emily Fortuna, 2012-02-28 18:29:07]

lgtm. 

Originally test.dart wasn't retrying after DRT crashes, and I added it in at
Bill's request. This was to provide a more accurate count of tests that were
actually passing (in the original test.py and test.dart there was a case where
we could have a false pass: we'd report the test's expected value if DRT crashed
with that particular error (GTK...)). Rerunning DRT eliminated the false
positives we could have been letting through.  Bill can probably give you more
details on why/how this worked.

(Good catch on the infinite loop, though -- sorry!)