Do not go infinite loop if test fails constantly.

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 106 matching lines @@
    */
   String compilerPath;
   /**
    * The arguments for the compilation command.
    */
   List<String> compilerArguments;
   /**
    * Indicates the number of potential retries remaining, to compensate for
    * flaky browser tests.
    */
-  bool numRetries;
+  int numRetries;
 
   BrowserTestCase(displayName,
                     this.compilerPath,
                     this.compilerArguments,
                     executablePath,
                     arguments,
                     configuration,
                     completedHandler,
                     expectedOutcomes,
                     [isNegative = false]) : super(displayName,
@@ skipping 71 matching lines @@
     // Browser case:
     // If the browser test failed, it may have been because DumpRenderTree
     // and the virtual framebuffer X server didn't hook up, or DRT crashed with
     // a core dump. Sometimes DRT crashes after it has set the stdout to PASS,
     // so we have to do this check first.
     for (String line in stderr) {
       if (line.contains('Gtk-WARNING **: cannot open display: :99') ||
         line.contains('Failed to run command. return code=1')) {
         // If we get the X server error, or DRT crashes with a core dump, retry
         // the test.
-        requestRetry = true;
+        if (testCase.dynamic.numRetries > 0) {
+          requestRetry = true;
+        }
         return true;
       }
     }
 
     // Browser tests fail unless stdout contains
     // 'Content-Type: text/plain\nPASS'.
     String previous_line = '';
     for (String line in stdout) {
       if (line == 'PASS' && previous_line == 'Content-Type: text/plain') {
         return (exitCode != 0 && !hasCrashed);
@@ skipping 46 matching lines @@
     if (allowRetries != null && allowRetries
         && testCase.configuration['component'] == 'webdriver' &&
         testCase.output.unexpectedOutput && testCase.numRetries > 0) {
       // Selenium tests can be flaky. Try rerunning.
       testCase.output.requestRetry = true;
     }
     if (testCase.output.requestRetry) {
       testCase.output.requestRetry = false;
       this.timedOut = false;
       testCase.dynamic.numRetries--;
-      print("Potential flake. Re-running " + testCase.displayName);
+      print("Potential flake. Re-running ${testCase.displayName} (${testCase.dynamic.numRetries} remains)");

[Mads Ager (google), 2012/02/28 17:06:56]

Long line.

[antonm, 2012/02/28 17:20:43]

Done.  I am using + for now as "aa" "bb" syntax doesn't work for me right now.

       this.start();
     } else {
       testCase.completed();
     }
   }
 
   void compilerExitHandler(int exitCode) {
     if (exitCode != 0) {
       stderr.add('test.dart: Compilation step failed (exit code $exitCode)\n');
       exitHandler(exitCode);
@@ skipping 460 matching lines @@
         // the developer doesn't waste his or her time trying to fix a bunch of
         // tests that appear to be broken but were actually just flakes that
         // didn't get retried because there had already been one failure.
         bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
         new RunningProcess(test, allowRetry, this).start();
       }
       _numProcesses++;
     }
   }
 }