Issue 9500014: Add statusCode and reasonPhrase getters and setters to the HttpResponse interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9500014: Add statusCode and reasonPhrase getters and setters to the HttpResponse interface (Closed)

Created:
8 years, 9 months ago by Søren Gjesse

Modified:
8 years, 9 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add statusCode and reasonPhrase getters and setters to the HttpResponse interface These where missing in the interface. R=ager@google.com BUG=dart:1919 TEST=tests/standalone/src/HttpTest.dart Committed: https://code.google.com/p/dart/source/detail?r=4750

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -19 lines)			Patch
M	runtime/bin/http.dart	View	1	2 chunks	+17 lines, -8 lines	0 comments	Download
M	runtime/bin/http_impl.dart	View		6 chunks	+19 lines, -11 lines	0 comments	Download
M	tests/standalone/src/HttpTest.dart	View		4 chunks	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

lgtm https://chromiumcodereview.appspot.com/9500014/diff/1/runtime/bin/http.dart File runtime/bin/http.dart (right): https://chromiumcodereview.appspot.com/9500014/diff/1/runtime/bin/http.dart#newcode173 runtime/bin/http.dart:173: int get statusCode(); These in the interface should ...

8 years, 9 months ago (2012-02-29 12:34:12 UTC) #2

Søren Gjesse

8 years, 9 months ago (2012-02-29 12:50:07 UTC) #3

https://chromiumcodereview.appspot.com/9500014/diff/1/runtime/bin/http.dart
File runtime/bin/http.dart (right):

https://chromiumcodereview.appspot.com/9500014/diff/1/runtime/bin/http.dart#n...
runtime/bin/http.dart:173: int get statusCode();
On 2012/02/29 12:34:12, Mads Ager wrote:
> These in the interface should just be
> 
> int statusCode;
> String reasonPhrase;

Good point. Did the same for contentLength and keepAlive.

Expand Messages | Collapse Messages