Add statusCode and reasonPhrase getters and setters to the HttpResponse interface

runtime/bin/http_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Global constants.
 class _Const {
   // Bytes for "HTTP/1.0".
   static final HTTP10 = const [72, 84, 84, 80, 47, 49, 46, 48];
   // Bytes for "HTTP/1.1".
   static final HTTP11 = const [72, 84, 84, 80, 47, 49, 46, 49];
@@ skipping 650 matching lines @@
 
 
 // HTTP response object for sending a HTTP response.
 class _HttpResponse extends _HttpRequestResponseBase implements HttpResponse {
   static final int START = 0;
   static final int HEADERS_SENT = 1;
   static final int DONE = 2;
 
   _HttpResponse(_HttpConnection httpConnection)
       : super(httpConnection),
-        statusCode = HttpStatus.OK,
+        _statusCode = HttpStatus.OK,
         _state = START;
 
   void set contentLength(int contentLength) {
     if (_outputStream != null) return new HttpException("Header already sent");
     _contentLength = contentLength;
   }
+
   void set keepAlive(bool keepAlive) {
     if (_outputStream != null) return new HttpException("Header already sent");
     _keepAlive = keepAlive;
   }
 
+  int get statusCode() => _statusCode;
+  void set statusCode(int statusCode) {
+    if (_outputStream != null) return new HttpException("Header already sent");
+    _statusCode = statusCode;
+  }
+
+  String get reasonPhrase() => _findReasonPhrase(_statusCode);
+  void set reasonPhrase(String reasonPhrase) => _reasonPhrase = reasonPhrase;
+
   // Set a header on the response. NOTE: If the same header is set
   // more than once only the last one will be part of the response.
   void setHeader(String name, String value) {
     if (_outputStream != null) return new HttpException("Header already sent");
     _setHeader(name, value);
   }
 
   OutputStream get outputStream() {
     if (_state == DONE) throw new HttpException("Response closed");
     if (_outputStream == null) {
@@ skipping 42 matching lines @@
 
   void _streamSetCloseHandler(callback()) {
     // TODO(sgjesse): Handle this.
   }
 
   void _streamSetErrorHandler(callback()) {
     // TODO(sgjesse): Handle this.
   }
 
   String _findReasonPhrase(int statusCode) {
-    if (reasonPhrase != null) {
-      return reasonPhrase;
+    if (_reasonPhrase != null) {
+      return _reasonPhrase;
     }
 
     switch (statusCode) {
       case HttpStatus.CONTINUE: return "Continue";
       case HttpStatus.SWITCHING_PROTOCOLS: return "Switching Protocols";
       case HttpStatus.OK: return "OK";
       case HttpStatus.CREATED: return "Created";
       case HttpStatus.ACCEPTED: return "Accepted";
       case HttpStatus.NON_AUTHORITATIVE_INFORMATION:
         return "Non-Authoritative Information";
@@ skipping 39 matching lines @@
     }
   }
 
   bool _writeHeader() {
     List<int> data;
     OutputStream stream = _httpConnection.outputStream;
 
     // Write status line.
     stream.write(_Const.HTTP11);
     _writeSP();
-    data = statusCode.toString().charCodes();
+    data = _statusCode.toString().charCodes();
     stream.write(data);
     _writeSP();
-    data = _findReasonPhrase(statusCode).charCodes();
+    data = reasonPhrase.charCodes();
     stream.write(data);
     _writeCRLF();
 
     // Determine the value of the "Connection" header
     // based on the keep alive state.
     setHeader("Connection", keepAlive ? "keep-alive" : "close");
     // Determine the value of the "Transfer-Encoding" header based on
     // whether the content length is known.
     if (_contentLength >= 0) {
       setHeader("Content-Length", _contentLength.toString());
     } else {
       setHeader("Transfer-Encoding", "chunked");
     }
 
     // Write headers.
     bool allWritten = _writeHeaders();
     _state = HEADERS_SENT;
     return allWritten;
   }
 
   // Response status code.
-  int statusCode;
-  String reasonPhrase;
+  int _statusCode;
+  String _reasonPhrase;
   _HttpOutputStream _outputStream;
   int _state;
 }
 
 
 class _HttpInputStream extends _BaseDataInputStream implements InputStream {
   _HttpInputStream(_HttpRequestResponseBase this._requestOrResponse) {
     _checkScheduleCallbacks();
   }
 
@@ skipping 249 matching lines @@
         _state = START {
     _connection = connection;
     // Default GET requests to have no content.
     if (_method == "GET") {
       _contentLength = 0;
     }
   }
 
   void set contentLength(int contentLength) => _contentLength = contentLength;
   void set keepAlive(bool keepAlive) => _keepAlive = keepAlive;
-  int get statusCode() { return _statusCode; }
-  String get reasonPhrase() { return _reasonPhrase; }
 
   void setHeader(String name, String value) {
     _setHeader(name, value);
   }
 
   bool writeString(String string) {
     outputStream;
     return _writeString(string);
   }
 
@@ skipping 83 matching lines @@
 }
 
 
 class _HttpClientResponse
     extends _HttpRequestResponseBase implements HttpClientResponse {
   _HttpClientResponse(_HttpClientConnection connection)
       : super(connection) {
     _connection = connection;
   }
 
-  int get statusCode() { return _statusCode; }
-  int get reasonPhrase() { return _reasonPhrase; }
+  int get statusCode() => _statusCode;
+  String get reasonPhrase() => _reasonPhrase;
   Map get headers() => _headers;
 
   InputStream get inputStream() {
     if (_inputStream == null) {
       _inputStream = new _HttpInputStream(this);
     }
     return _inputStream;
   }
 
   void _requestStartHandler(String method, String uri) {
@@ skipping 341 matching lines @@
       } else {
         value = queryString.substring(currentPosition, position);
         currentPosition = position + 1;
       }
       result[HttpUtil.decodeUrlEncodedString(name)] =
         HttpUtil.decodeUrlEncodedString(value);
     }
     return result;
   }
 }