Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 9487005: Move back to having File.open{Input,Output}Stream return the stream directly. (Closed)

Created:
8 years, 9 months ago by Mads Ager (google)
Modified:
8 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move back to having File.open{Input,Output}Stream return the stream directly. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4677

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -192 lines) Patch
M frog/file_system_vm.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/file.dart View 3 chunks +4 lines, -42 lines 0 comments Download
M runtime/bin/file_impl.dart View 4 chunks +3 lines, -44 lines 0 comments Download
M samples/actors/samples/sssp/sssp-util.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/src/FileInputStreamTest.dart View 6 chunks +4 lines, -30 lines 0 comments Download
M tests/standalone/src/FileOutputStreamTest.dart View 4 chunks +9 lines, -45 lines 0 comments Download
M tests/standalone/src/FileTest.dart View 9 chunks +11 lines, -11 lines 0 comments Download
M tests/standalone/src/ReadIntoConstList.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/src/StreamPipeTest.dart View 5 chunks +9 lines, -9 lines 0 comments Download
M tools/testing/dart/status_file_parser.dart View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
8 years, 9 months ago (2012-02-28 12:05:16 UTC) #1
Søren Gjesse
8 years, 9 months ago (2012-02-28 12:13:41 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698