Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: tools/testing/dart/status_file_parser.dart

Issue 9487005: Move back to having File.open{Input,Output}Stream return the stream directly. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/src/StreamPipeTest.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/status_file_parser.dart
diff --git a/tools/testing/dart/status_file_parser.dart b/tools/testing/dart/status_file_parser.dart
index ec701111fe3cb5c942eee4a826e3ac1c58412c20..58e24831d55f2c2d489390d7f14cbcd02d3cc9b1 100644
--- a/tools/testing/dart/status_file_parser.dart
+++ b/tools/testing/dart/status_file_parser.dart
@@ -59,14 +59,7 @@ void ReadConfigurationInto(path, sections, onDone) {
if (!file.existsSync()) {
throw new Exception('Cannot find test status file $path');
}
- // TODO(1797): When the checked in binary is updated to include the
- // openInputStreamSync API remove this try/catch.
- InputStream file_stream;
- try {
- file_stream = file.openInputStreamSync();
- } catch (NoSuchMethodException e) {
- file_stream = file.openInputStream();
- }
+ InputStream file_stream = file.openInputStream();
StringInputStream lines = new StringInputStream(file_stream);
Section current = new Section.always();
« no previous file with comments | « tests/standalone/src/StreamPipeTest.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698